Return-Path: Received: from fieldses.org ([173.255.197.46]:59967 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932378AbbGJOSP (ORCPT ); Fri, 10 Jul 2015 10:18:15 -0400 Date: Fri, 10 Jul 2015 10:18:14 -0400 To: Chuck Lever Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v1 5/5] svcrdma: Boost NFS READ/WRITE payload size maximum Message-ID: <20150710141814.GA31121@fieldses.org> References: <20150709204230.8481.45457.stgit@klimt.1015granger.net> <20150709204546.8481.65857.stgit@klimt.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150709204546.8481.65857.stgit@klimt.1015granger.net> From: bfields@fieldses.org (J. Bruce Fields) Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Jul 09, 2015 at 04:45:47PM -0400, Chuck Lever wrote: > Increased to 1 megabyte. Why not more or less? Why do we even have this constant, why shouldn't we just use RPCSVC_MAXPAYLOAD? --b. > > Signed-off-by: Chuck Lever > --- > > include/linux/sunrpc/svc_rdma.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h > index 13af61b..1bca6dd 100644 > --- a/include/linux/sunrpc/svc_rdma.h > +++ b/include/linux/sunrpc/svc_rdma.h > @@ -172,7 +172,7 @@ struct svcxprt_rdma { > #define RDMAXPRT_SQ_PENDING 2 > #define RDMAXPRT_CONN_PENDING 3 > > -#define RPCRDMA_MAX_SVC_SEGS (64) /* server max scatter/gather */ > +#define RPCRDMA_MAX_SVC_SEGS (256) /* server max scatter/gather */ > #if RPCSVC_MAXPAYLOAD < (RPCRDMA_MAX_SVC_SEGS << PAGE_SHIFT) > #define RPCRDMA_MAXPAYLOAD RPCSVC_MAXPAYLOAD > #else > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html