Return-Path: Received: from fieldses.org ([173.255.197.46]:60005 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754746AbbGJPyY (ORCPT ); Fri, 10 Jul 2015 11:54:24 -0400 Date: Fri, 10 Jul 2015 11:54:24 -0400 From: "J. Bruce Fields" To: Chuck Lever Cc: Linux NFS Mailing List , linux-rdma@vger.kernel.org Subject: Re: [PATCH v1 5/5] svcrdma: Boost NFS READ/WRITE payload size maximum Message-ID: <20150710155424.GD31121@fieldses.org> References: <20150709204230.8481.45457.stgit@klimt.1015granger.net> <20150709204546.8481.65857.stgit@klimt.1015granger.net> <20150710141814.GA31121@fieldses.org> <11D08769-F6EB-4696-8910-8B207B20CC10@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <11D08769-F6EB-4696-8910-8B207B20CC10@oracle.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Jul 10, 2015 at 10:59:48AM -0400, Chuck Lever wrote: > > On Jul 10, 2015, at 10:18 AM, bfields@fieldses.org wrote: > > > On Thu, Jul 09, 2015 at 04:45:47PM -0400, Chuck Lever wrote: > >> Increased to 1 megabyte. > > > > Why not more or less? > > > > Why do we even have this constant, why shouldn't we just use > > RPCSVC_MAXPAYLOAD? > > The payload size maximum for RDMA is based on RPCRDMA_MAX_SVC_SEGS. > We could reverse the relationship and make RPCRDMA_MAX_SVC_SEGS > based on RPCSVC_MAXPAYLOAD divided by the platform’s page size. But there'd be no reason to do that, because we're not using RPCRDMA_MAX_SVC_SEGS anywhere. Should we be? --b. > > > > --b. > > > >> > >> Signed-off-by: Chuck Lever > >> --- > >> > >> include/linux/sunrpc/svc_rdma.h | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h > >> index 13af61b..1bca6dd 100644 > >> --- a/include/linux/sunrpc/svc_rdma.h > >> +++ b/include/linux/sunrpc/svc_rdma.h > >> @@ -172,7 +172,7 @@ struct svcxprt_rdma { > >> #define RDMAXPRT_SQ_PENDING 2 > >> #define RDMAXPRT_CONN_PENDING 3 > >> > >> -#define RPCRDMA_MAX_SVC_SEGS (64) /* server max scatter/gather */ > >> +#define RPCRDMA_MAX_SVC_SEGS (256) /* server max scatter/gather */ > >> #if RPCSVC_MAXPAYLOAD < (RPCRDMA_MAX_SVC_SEGS << PAGE_SHIFT) > >> #define RPCRDMA_MAXPAYLOAD RPCSVC_MAXPAYLOAD > >> #else > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Chuck Lever > >