Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:57247 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbbGMHE1 (ORCPT ); Mon, 13 Jul 2015 03:04:27 -0400 Date: Mon, 13 Jul 2015 00:04:26 -0700 From: Christoph Hellwig To: Anna Schumaker Cc: Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 8/9] NFS: Rename nfs_commit_unstable_pages() to nfs_write_inode() Message-ID: <20150713070426.GL26245@infradead.org> References: <1436561897-8051-1-git-send-email-Anna.Schumaker@Netapp.com> <1436561897-8051-9-git-send-email-Anna.Schumaker@Netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1436561897-8051-9-git-send-email-Anna.Schumaker@Netapp.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Jul 10, 2015 at 04:58:16PM -0400, Anna Schumaker wrote: > All nfs_write_inode() does is pass its arguments to > nfs_commit_unstable_pages(). Let's cut out the middle man and have > nfs_write_pages() do the work directly. > > Signed-off-by: Anna Schumaker Looks good, Reviewed-by: Christoph Hellwig