Return-Path: Received: from mail-la0-f46.google.com ([209.85.215.46]:33051 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbbGOS0R (ORCPT ); Wed, 15 Jul 2015 14:26:17 -0400 Received: by laem6 with SMTP id m6so29863812lae.0 for ; Wed, 15 Jul 2015 11:26:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20150713160617.17630.97475.stgit@manet.1015granger.net> <20150713163048.17630.86326.stgit@manet.1015granger.net> <55A55C63.50403@talpey.com> Date: Wed, 15 Jul 2015 23:56:15 +0530 Message-ID: Subject: Re: [PATCH v2 07/14] xprtrdma: Remove logic that constructs RDMA_MSGP type calls From: Devesh Sharma To: Chuck Lever Cc: Tom Talpey , linux-rdma@vger.kernel.org, Linux NFS Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: with MAX_IOVS set to 2 iozone passes with ocrdma device. My testing includes both the series of svcrdma and xprtrdma. On Wed, Jul 15, 2015 at 12:31 AM, Chuck Lever wrote: > > On Jul 14, 2015, at 3:00 PM, Tom Talpey wrote: > >> On 7/13/2015 12:30 PM, Chuck Lever wrote: >>> RDMA_MSGP type calls insert a zero pad in the middle of the RPC >>> message to align the RPC request's data payload to the server's >>> alignment preferences. A server can then "page flip" the payload >>> into place to avoid a data copy in certain circumstances. However: >>> ... >>> >>> Clean up the marshaling code by removing the logic that constructs >>> RDMA_MSGP type calls. This also reduces the maximum send iovec size >>> from four to just two elements. >>> >> >>> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h >>> index 8219011..0b50103 100644 >>> --- a/net/sunrpc/xprtrdma/xprt_rdma.h >>> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h >> ...> >>> +#define RPCRDMA_MAX_IOVS (4) >>> + >> >> So, shouldn't this constant be "2"? The extra 2 iov's were used >> only for constructing the pad. > > Yes, thanks. I folded a couple of patches together into this > one, and forgot to update the constant. > > > -- > Chuck Lever > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html