Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:50791 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755717AbbHZNRl (ORCPT ); Wed, 26 Aug 2015 09:17:41 -0400 Date: Wed, 26 Aug 2015 06:17:41 -0700 From: Christoph Hellwig To: Peng Tao Cc: linux-fsdevel@vger.kernel.org, Trond Myklebust , Anna Schumaker , Zach Brown , Darren Hart , bfields@fieldses.org, Jeff Layton , linux-nfs@vger.kernel.org, "Darrick J. Wong" , linux-btrfs@vger.kernel.org Subject: Re: [PATCH-RFC-RESEND 2/9] vfs/btrfs: add .clone_range file operation Message-ID: <20150826131741.GA22249@infradead.org> References: <1440577010-122867-1-git-send-email-tao.peng@primarydata.com> <1440577010-122867-3-git-send-email-tao.peng@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1440577010-122867-3-git-send-email-tao.peng@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: You need to eep the existing defintion, either as a duplicate with a comment, or by including the uapi fs.h and defininin it to the new name. Also this will break cifs, which uses the BTRFS_IOC_CLONE defintion already.