Return-Path: Received: from mail-yk0-f177.google.com ([209.85.160.177]:36451 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751907AbbIQMj5 (ORCPT ); Thu, 17 Sep 2015 08:39:57 -0400 Received: by ykdt18 with SMTP id t18so15060507ykd.3 for ; Thu, 17 Sep 2015 05:39:57 -0700 (PDT) From: Jeff Layton To: Al Viro Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] fs: export flush_delayed_fput Date: Thu, 17 Sep 2015 08:39:47 -0400 Message-Id: <1442493587-32499-5-git-send-email-jeff.layton@primarydata.com> In-Reply-To: <1442493587-32499-1-git-send-email-jeff.layton@primarydata.com> References: <1442493587-32499-1-git-send-email-jeff.layton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: ...and clean up the comments over it a bit. The nfsd code will need to be able to call back into this. Signed-off-by: Jeff Layton --- fs/file_table.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index 95361d2b8a08..899c19687cfa 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -246,20 +246,24 @@ static void ____fput(struct callback_head *work) static DECLARE_DELAYED_WORK(delayed_fput_work, delayed_fput); -/* - * If kernel thread really needs to have the final fput() it has done - * to complete, call this. The only user right now is the boot - we - * *do* need to make sure our writes to binaries on initramfs has - * not left us with opened struct file waiting for __fput() - execve() - * won't work without that. Please, don't add more callers without - * very good reasons; in particular, never call that with locks - * held and never call that from a thread that might need to do - * some work on any kind of umount. +/** + * flush_delayed_fput - ensure that all delayed_fput work is complete + * + * If kernel thread or task that has used fput_queue really needs to have the + * final fput() it has done to complete, call this. One of the main users is + * the boot - we *do* need to make sure our writes to binaries on initramfs has + * not left us with opened struct file waiting for __fput() - execve() won't + * work without that. + * + * Please, don't add more callers without very good reasons; in particular, + * never call that with locks held and never from a thread that might need to + * do some work on any kind of umount. */ void flush_delayed_fput(void) { flush_delayed_work(&delayed_fput_work); } +EXPORT_SYMBOL(flush_delayed_fput); /** * fput - put a struct file reference -- 2.4.3