Return-Path: Received: from mail-oi0-f43.google.com ([209.85.218.43]:34330 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754511AbbIWM7h (ORCPT ); Wed, 23 Sep 2015 08:59:37 -0400 Received: by oiev17 with SMTP id v17so22962870oie.1 for ; Wed, 23 Sep 2015 05:59:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1442892922-10834-1-git-send-email-tao.peng@primarydata.com> <56025A7D.2060207@gmail.com> <56025AE6.6020808@gmail.com> <56026273.8040707@gmail.com> <56029EF5.1000507@gmail.com> Date: Wed, 23 Sep 2015 08:59:36 -0400 Message-ID: Subject: Re: [PATCH v2] NFS41: make close wait for layoutreturn From: Trond Myklebust To: Kinglong Mee Cc: Peng Tao , Linux NFS Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Sep 23, 2015 at 8:52 AM, Trond Myklebust wrote: > On Wed, Sep 23, 2015 at 8:45 AM, Kinglong Mee wrote: >> On 9/23/2015 20:05, Trond Myklebust wrote: >>> On Wed, Sep 23, 2015 at 4:27 AM, Kinglong Mee wrote: >>>> I find the inode returned from nfs_igrab_and_active is NULL >>>> in _nfs4_proc_delegreturn(), >>>> >>>> data->inode = nfs_igrab_and_active(inode); >>>> >>>> So that, NFS_I(inode) causes the panic. >>> >>> I've added a check for ino == NULL to nfs4_wait_on_layoutreturn()... >> >> Yes, that's right. >> >> But you add the checking at the wrong place in pnfs_wait_on_layoutreturn() at your tree. >> > > Sigh...errno = ENOCOFFEE; > > Thanks for reviewing! I'll revert and fix up again... :-/ > Fixed now... Cheers Trond