Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:57232 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753203AbbIYLZw (ORCPT ); Fri, 25 Sep 2015 07:25:52 -0400 From: Andreas Gruenbacher To: Andreas Gruenbacher Cc: "J. Bruce Fields" , LKML , linux-fsdevel , Linux NFS Mailing List , Linux API Mailing List , linux-cifs@vger.kernel.org, LSM List Subject: Re: [RFC v7 25/41] richacl: Isolate the owner and group classes Date: Fri, 25 Sep 2015 13:25:41 +0200 Message-Id: <1443180341-22911-1-git-send-email-agruenba@redhat.com> References: <1441448856-13478-1-git-send-email-agruenba@redhat.com> <1441448856-13478-26-git-send-email-agruenba@redhat.com> <20150922190224.GA19127@fieldses.org> In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: Here is another minor improvement that produces deny aces with fewer permissions in them and avoids creating unnecessary deny aces in some cases. Andreas --- fs/richacl_compat.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/richacl_compat.c b/fs/richacl_compat.c index 2f53394..bc0bcfe 100644 --- a/fs/richacl_compat.c +++ b/fs/richacl_compat.c @@ -605,14 +605,13 @@ __richacl_isolate_who(struct richacl_alloc *alloc, struct richace *who, int n; /* - * Compute the permissions already denied to @who. There are no + * Compute the permissions already defined for @who. There are no * everyone@ deny aces left in the acl at this stage. */ richacl_for_each_entry(ace, acl) { if (richace_is_inherit_only(ace)) continue; - if (richace_is_same_identifier(acl, ace, who) && - richace_is_deny(ace)) + if (richace_is_same_identifier(acl, ace, who)) deny &= ~ace->e_mask; } if (!deny) -- 2.4.3