Return-Path: Received: from fieldses.org ([173.255.197.46]:35000 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933168AbbIYUZQ (ORCPT ); Fri, 25 Sep 2015 16:25:16 -0400 Date: Fri, 25 Sep 2015 16:25:15 -0400 From: "J. Bruce Fields" To: Andrzej Hajda Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Jeff Layton , Trond Myklebust , Anna Schumaker , "David S. Miller" , linux-nfs@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 01/19] SUNRPC: fix variable type Message-ID: <20150925202515.GA15653@fieldses.org> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> <1443103227-25612-2-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1443103227-25612-2-git-send-email-a.hajda@samsung.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: ACK. Assuming Trond gets this.--b. On Thu, Sep 24, 2015 at 04:00:09PM +0200, Andrzej Hajda wrote: > Due to incorrect len type bc_send_request returned always zero. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > Hi, > > To avoid problems with too many mail recipients I have sent whole > patchset only to LKML. Anyway patches have no dependencies. > > Regards > Andrzej > --- > net/sunrpc/xprtsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c > index 1a85e0e..60fb002 100644 > --- a/net/sunrpc/xprtsock.c > +++ b/net/sunrpc/xprtsock.c > @@ -2472,7 +2472,7 @@ static int bc_send_request(struct rpc_task *task) > { > struct rpc_rqst *req = task->tk_rqstp; > struct svc_xprt *xprt; > - u32 len; > + int len; > > dprintk("sending request with xid: %08x\n", ntohl(req->rq_xid)); > /* > -- > 1.9.1