Return-Path: Received: from mail-oi0-f53.google.com ([209.85.218.53]:33039 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbbIZAPT (ORCPT ); Fri, 25 Sep 2015 20:15:19 -0400 Received: by oixx17 with SMTP id x17so66405535oix.0 for ; Fri, 25 Sep 2015 17:15:19 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1443214096-12769-9-git-send-email-Anna.Schumaker@Netapp.com> References: <1443214096-12769-1-git-send-email-Anna.Schumaker@Netapp.com> <1443214096-12769-9-git-send-email-Anna.Schumaker@Netapp.com> From: Andy Lutomirski Date: Fri, 25 Sep 2015 17:14:59 -0700 Message-ID: Subject: Re: [PATCH v3 8/9] vfs: copy_file_range() can do a pagecache copy with splice To: Anna Schumaker Cc: linux-nfs@vger.kernel.org, Linux btrfs Developers List , Linux FS Devel , Linux API , Zach Brown , Al Viro , Chris Mason , "Darrick J. Wong" , Michael Kerrisk-manpages , andros@netapp.com, Christoph Hellwig Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Sep 25, 2015 at 1:48 PM, Anna Schumaker wrote: > The NFS server will need some kind offallback for filesystems that don't > have any kind of copy acceleration, and it should be generally useful to > have an in-kernel copy to avoid lots of switches between kernel and user > space. > > I make this configurable by adding two new flags. Users who only want a > reflink can pass COPY_FR_REFLINK, and users who want a full data copy can > pass COPY_FR_COPY. The default (flags=0) means to first attempt a > reflink, but use the pagecache if that fails. > Can you clarify how the subject line fits in? I'm a bit lost. --Andy