Return-Path: Received: from mx143.netapp.com ([216.240.21.24]:13717 "EHLO mx143.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933633AbbI1Opj (ORCPT ); Mon, 28 Sep 2015 10:45:39 -0400 From: Anna Schumaker Subject: Re: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers To: Steve Wise , , References: <20150921172423.9761.92399.stgit@build2.ogc.int> <56094F16.3040608@opengridcomputing.com> CC: , Message-ID: <56095286.6030201@Netapp.com> Date: Mon, 28 Sep 2015 10:45:26 -0400 MIME-Version: 1.0 In-Reply-To: <56094F16.3040608@opengridcomputing.com> Content-Type: text/plain; charset="utf-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Steve, On 09/28/2015 10:30 AM, Steve Wise wrote: > On 9/21/2015 12:24 PM, Steve Wise wrote: >> Otherwise a FRMR completion can cause a touch-after-free crash. >> >> In xprt_rdma_destroy(), call rpcrdma_buffer_destroy() only after calling >> rpcrdma_ep_destroy(). >> >> In rpcrdma_ep_destroy(), disconnect the cm_id first which should flush the >> qp, then drain the cqs, then destroy the qp, and finally destroy the cqs. >> >> Signed-off-by: Steve Wise >> Tested-by: Chuck Lever >> --- > > Hey Trond, I'm hoping this can make 4.3-rc (and stable if you agree). This patch looks fine to me. I'll pass it on to Trond! I'll save patch 3/3 for the Linux 4.4 merge. Thanks, Anna > > Thanks, > > Steve. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html