Return-Path: Received: from mail-wi0-f171.google.com ([209.85.212.171]:38663 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933924AbbI1Qvt convert rfc822-to-8bit (ORCPT ); Mon, 28 Sep 2015 12:51:49 -0400 MIME-Version: 1.0 In-Reply-To: <20150928162905.GE1358@fieldses.org> References: <1443391772-10171-1-git-send-email-agruenba@redhat.com> <1443391772-10171-11-git-send-email-agruenba@redhat.com> <20150928160855.GD1358@fieldses.org> <20150928162905.GE1358@fieldses.org> Date: Mon, 28 Sep 2015 18:51:47 +0200 Message-ID: Subject: Re: [PATCH v8 10/41] richacl: Permission check algorithm From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= To: "J. Bruce Fields" Cc: Andreas Gruenbacher , Alexander Viro , "Theodore Ts'o" , Andreas Dilger , Jeff Layton , Trond Myklebust , Anna Schumaker , linux-ext4@vger.kernel.org, Linux Kernel Mailing List , Linux FS-devel Mailing List , Linux NFS Mailing List , Linux API Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: 2015-09-28 18:29 GMT+02:00 J. Bruce Fields : > On Mon, Sep 28, 2015 at 06:25:23PM +0200, Andreas Grünbacher wrote: >> 2015-09-28 18:08 GMT+02:00 J. Bruce Fields : >> > The above also skips the following group_mask application on any unix >> > group. >> >> Really? How does it do that? > > Sorry, I meant "unix user", not "unix group"! Indeed, that's a bit tricky. Probably worth changing if just for clarity: - goto entry_matches_owner; + if (uid_eq(current_fsuid(), inode->i_uid)) + goto entry_matches_owner; Thanks, Andreas