Return-Path: Received: from mail-oi0-f42.google.com ([209.85.218.42]:35577 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbbKCQZr (ORCPT ); Tue, 3 Nov 2015 11:25:47 -0500 Received: by oifu63 with SMTP id u63so11829377oif.2 for ; Tue, 03 Nov 2015 08:25:46 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1446563847-14005-46-git-send-email-agruenba@redhat.com> References: <1446563847-14005-1-git-send-email-agruenba@redhat.com> <1446563847-14005-46-git-send-email-agruenba@redhat.com> Date: Tue, 3 Nov 2015 11:25:46 -0500 Message-ID: Subject: Re: [PATCH v13 45/51] sunrpc: Allow to demand-allocate pages to encode into From: Trond Myklebust To: Andreas Gruenbacher Cc: Alexander Viro , "Theodore Ts'o" , Andreas Dilger , "J. Bruce Fields" , Jeff Layton , Anna Schumaker , Dave Chinner , linux-ext4@vger.kernel.org, xfs@oss.sgi.com, Linux Kernel Mailing List , Linux FS-devel Mailing List , Linux NFS Mailing List , linux-cifs@vger.kernel.org, Linux API Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Nov 3, 2015 at 10:17 AM, Andreas Gruenbacher wrote: > When encoding large, variable-length objects such as acls into xdr_bufs, > it is easier to allocate buffer pages on demand rather than precomputing > the required buffer size. > NACK. We're not doing allocations from inside the XDR encoders. This can and should be done before calling into the SUNRPC layer. Trond