Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:50969 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033581AbbKFUFL (ORCPT ); Fri, 6 Nov 2015 15:05:11 -0500 Date: Fri, 6 Nov 2015 23:04:44 +0300 From: Dan Carpenter To: Anna Schumaker Cc: Trond Myklebust , Chuck Lever , Jeff Layton , Sagi Grimberg , linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch 2/2] xprtrdma: checking for NULL instead of IS_ERR() Message-ID: <20151106200444.GO7289@mwanda> References: <20151105083952.GB19405@mwanda> <563CF2CA.5050409@Netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <563CF2CA.5050409@Netapp.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Nov 06, 2015 at 01:34:50PM -0500, Anna Schumaker wrote: > On 11/05/2015 03:39 AM, Dan Carpenter wrote: > > The rpcrdma_create_req() function returns error pointers or success. It > > never returns NULL. > > > > Fixes: f531a5dbc451 ('xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers') > > Signed-off-by: Dan Carpenter > > Thanks, Dan! These patches don't look urgent, so if it's okay with you then I'll save them for 4.5. To be honest, I only ever care about linux-next and not released versions. :P As long as it's in linux-next I'll be happy. regards, dan carpenter