Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:46114 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbcDLRBY (ORCPT ); Tue, 12 Apr 2016 13:01:24 -0400 Date: Tue, 12 Apr 2016 10:01:21 -0700 From: Christoph Hellwig To: Chuck Lever Cc: Steve Wise , linux-rdma , Linux NFS Mailing List Subject: Re: [PATCH v1 05/18] xprtrdma: Avoid using Write list for small NFS READ requests Message-ID: <20160412170121.GA2052@infradead.org> References: <20160411200323.20531.8893.stgit@manet.1015granger.net> <20160411201050.20531.53651.stgit@manet.1015granger.net> <033901d19431$b3725d20$1a571760$@opengridcomputing.com> <65CBC59F-3005-44FE-8C70-9DDBC8507C9E@oracle.com> <20160412141533.GA16218@infradead.org> <06326E24-7170-4D09-A841-08ED31D143FF@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <06326E24-7170-4D09-A841-08ED31D143FF@oracle.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Apr 12, 2016 at 10:49:24AM -0400, Chuck Lever wrote: > >> No, pre-4.2 Linux servers have a bug that can be fixed by > >> applying the above commit, which shouldn't be difficult to > >> backport. > >> > >> Clients have always been allowed to send NFS READ this way. > > > > But the clients might be out in a the wild. I think we'll need at > > least a mount option to work around them. > > Huh? > > I'm talking about non-Linux clients. RFC 5666 allows > this behavior, it always has. The Linux server before > 9d11b51ce7c1 is broken, full stop. You are deliverately breaking exsisting and fairly recent clients. I see why we want to do this, but there needs to be an options that things keep working. The idea of upgrading your client from 4.6 to 4.7 and NFS simply not working anymore with the developer knowing it and not providing a workaround is simply not an option.