From: Anna Schumaker <Anna.Schumaker@netapp.com>
Subject: Re: [PATCH Version 4 01/10] NFS default callback ops
To: <andros@netapp.com>, <trond.myklebust@primarydata.com>
References: <1462993705-14673-1-git-send-email-andros@netapp.com>
 <1462993705-14673-2-git-send-email-andros@netapp.com>
CC: <bfields@fieldses.org>, <chuck.lever@oracle.com>,
        <linux-nfs@vger.kernel.org>
Message-ID: <6beca2b4-4951-fa56-f965-18863e85f700@Netapp.com>
Date: Tue, 17 May 2016 16:17:15 -0400
MIME-Version: 1.0
In-Reply-To: <1462993705-14673-2-git-send-email-andros@netapp.com>
Content-Type: text/plain; charset="utf-8"
Sender: linux-nfs-owner@vger.kernel.org

Hi Andy,

I think you're missing a word or two from the title of this patch.  I'm guessing it should say "rename default callback ops"?

Anna

On 05/11/2016 03:08 PM, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
> 
> Also use with refactored exchange_id for session trunking
> 
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
>  fs/nfs/nfs4proc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 327b8c3..da2aa2e 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -6784,12 +6784,12 @@ nfs41_same_server_scope(struct nfs41_server_scope *a,
>  }
>  
>  static void
> -nfs4_bind_one_conn_to_session_done(struct rpc_task *task, void *calldata)
> +nfs4_proc_default_done(struct rpc_task *task, void *calldata)
>  {
>  }
>  
> -static const struct rpc_call_ops nfs4_bind_one_conn_to_session_ops = {
> -	.rpc_call_done =  &nfs4_bind_one_conn_to_session_done,
> +static const struct rpc_call_ops nfs4_proc_default_ops = {
> +	.rpc_call_done =  &nfs4_proc_default_done,
>  };
>  
>  /*
> @@ -6820,7 +6820,7 @@ int nfs4_proc_bind_one_conn_to_session(struct rpc_clnt *clnt,
>  	struct rpc_task_setup task_setup_data = {
>  		.rpc_client = clnt,
>  		.rpc_xprt = xprt,
> -		.callback_ops = &nfs4_bind_one_conn_to_session_ops,
> +		.callback_ops = &nfs4_proc_default_ops,
>  		.rpc_message = &msg,
>  		.flags = RPC_TASK_TIMEOUT,
>  	};
>