Return-Path: Received: from fieldses.org ([173.255.197.46]:58092 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbcFOTYQ (ORCPT ); Wed, 15 Jun 2016 15:24:16 -0400 Date: Wed, 15 Jun 2016 15:24:15 -0400 From: "J. Bruce Fields" To: Andrew Elble Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH v3 0/3] Deal with lost delegations and EKEYEXPIRED Message-ID: <20160615192415.GB3848@fieldses.org> References: <1466009529-3421-1-git-send-email-aweits@rit.edu> <20160615192116.GA3848@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160615192116.GA3848@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Jun 15, 2016 at 03:21:16PM -0400, J. Bruce Fields wrote: > Looks good, thanks. > > On Wed, Jun 15, 2016 at 12:52:06PM -0400, Andrew Elble wrote: > > The majority of our lost delegation problems come from the inability > > to return the delegations when the credentials that obtained them > > have expired (conundrum mentioned in RFC 5661 18.35.3) > > I take it you've tested these and verified delegations aren't getting > lost? Are there client changes needed as well, or is the client already > doing the right thing? (Also: remind me what they symptoms ("lost delegation problems") actually were from the point of view of users? Does the client end up resending failing DELEGRETURNS and failing to make progress?) --b. > > --b. > > > > > ObMemoryJog: > > > > http://www.spinics.net/lists/linux-nfs/msg56230.html > > > > v3: removal of OP_IS_PUTFH_LIKE checks > > added clarification of addressing the conundrum > > > > Andrew Elble (3): > > nfs/nfsd: Move useful bitfield ops to a commonly accessible place > > nfsd: allow mach_creds_match to be used more broadly > > nfsd: implement machine credential support for some operations > > > > fs/nfsd/export.c | 10 ++++++++++ > > fs/nfsd/nfs4proc.c | 39 +++++++++++++++++++++++++++++++++++++ > > fs/nfsd/nfs4state.c | 32 ++++++++++++++++++++++++------- > > fs/nfsd/nfs4xdr.c | 51 ++++++++++++++++++++++--------------------------- > > fs/nfsd/nfsd.h | 5 +++++ > > fs/nfsd/state.h | 1 + > > fs/nfsd/xdr4.h | 5 +++++ > > include/linux/nfs4.h | 11 +++++++++++ > > include/linux/nfs_xdr.h | 11 ----------- > > 9 files changed, 119 insertions(+), 46 deletions(-) > > > > -- > > 2.6.3