Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:33986 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbcGUJIZ (ORCPT ); Thu, 21 Jul 2016 05:08:25 -0400 From: "Benjamin Coddington" To: "hch@infradead.org" Cc: "Trond Myklebust" , "List Linux" Subject: Re: [PATCH v4 24/28] Getattr doesn't require data sync semantics Date: Thu, 21 Jul 2016 05:10:03 -0400 Message-ID: In-Reply-To: References: <1467844205-76852-23-git-send-email-trond.myklebust@primarydata.com> <1467844205-76852-24-git-send-email-trond.myklebust@primarydata.com> <1467844205-76852-25-git-send-email-trond.myklebust@primarydata.com> <20160718034847.GA1195@infradead.org> <1468817945.5273.2.camel@primarydata.com> <20160719035843.GA24437@infradead.org> <20160721082216.GA15247@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: On 21 Jul 2016, at 4:32, Benjamin Coddington wrote: > On 21 Jul 2016, at 4:22, hch@infradead.org wrote: > >> On Wed, Jul 20, 2016 at 11:03:06AM -0400, Benjamin Coddington wrote: >>>>> This debug output is identical for every cycle of the loop. Have >>>>> to >>>>> stop for the >>>>> day.. more tomorrow. >>>>> >>>>> Ben >>>>> >>>> >>>> Duh??? It???s this patch: pNFS: Fix post-layoutget error handling >>>> in >>>> pnfs_update_layout() >>>> We have to pass through fatal errors??? I???ll fix it. >>> >>> That's indeed fixed it up, and generic/207 passes now. Thanks! >> >> So I spoke too soon in my last mail, generic/207 still fails for me >> with Trond's linux-next tree, although much later in the test now. >> >> Does it include the changes that are supposed to fix the issue? > > It should -- the v2 that fixed 207 for me is > 56b38a1f7c781519eef09c1668a3c97ea911f86b, the first version was > e35c2a0b3cd062a8941d21511719391b64437427, I think. I'll test again > too. Looks like we're back to the original problem - it fails with the inode size is 4k less than expected. The reason it worked for me was I had pnfs_ld debugging turned up which slowed things down enough to somehow catch the right size. Looks like the right size is returned in the CLOSE, but the inode's not getting updated. Ben