Return-Path: Received: from mga14.intel.com ([192.55.52.115]:28095 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965551AbcHBMwb (ORCPT ); Tue, 2 Aug 2016 08:52:31 -0400 From: Baole Ni To: trond.myklebust@primarydata.com, anna.schumaker@netapp.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, mhalcrow@google.com, kirill.shutemov@linux.intel.com, oneukum@suse.com Subject: [PATCH 1049/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:11:45 +0800 Message-Id: <20160802121145.20043-1-baolex.ni@intel.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- fs/nfs/filelayout/filelayoutdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfs/filelayout/filelayoutdev.c b/fs/nfs/filelayout/filelayoutdev.c index 4946ef4..c91488b 100644 --- a/fs/nfs/filelayout/filelayoutdev.c +++ b/fs/nfs/filelayout/filelayoutdev.c @@ -289,11 +289,11 @@ out: return ret; } -module_param(dataserver_retrans, uint, 0644); +module_param(dataserver_retrans, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(dataserver_retrans, "The number of times the NFSv4.1 client " "retries a request before it attempts further " " recovery action."); -module_param(dataserver_timeo, uint, 0644); +module_param(dataserver_timeo, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(dataserver_timeo, "The time (in tenths of a second) the " "NFSv4.1 client waits for a response from a " " data server before it retries an NFS request."); -- 2.9.2