Return-Path: Received: from mga04.intel.com ([192.55.52.120]:43557 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965294AbcHBMwJ (ORCPT ); Tue, 2 Aug 2016 08:52:09 -0400 From: Baole Ni To: bfields@fieldses.org, jlayton@poochiereds.net, trond.myklebust@primarydata.com, anna.schumaker@netapp.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, oneukum@suse.com Subject: [PATCH 1055/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:12:15 +0800 Message-Id: <20160802121215.20444-1-baolex.ni@intel.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- fs/nfsd/nfs4idmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c index 5b20577..7d4722c 100644 --- a/fs/nfsd/nfs4idmap.c +++ b/fs/nfsd/nfs4idmap.c @@ -46,7 +46,7 @@ * Turn off idmapping when using AUTH_SYS. */ static bool nfs4_disable_idmapping = true; -module_param(nfs4_disable_idmapping, bool, 0644); +module_param(nfs4_disable_idmapping, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(nfs4_disable_idmapping, "Turn off server's NFSv4 idmapping when using 'sec=sys'"); -- 2.9.2