Date: Thu, 11 Aug 2016 15:57:29 -0400
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v4 0/2] Eliminate race between LOCK and FREE_STATEID
Message-ID: <20160811195729.GB2114@fieldses.org>
References: <20160811143205.20488.82396.stgit@klimt.1015granger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <20160811143205.20488.82396.stgit@klimt.1015granger.net>
Sender: linux-nfs-owner@vger.kernel.org

On Thu, Aug 11, 2016 at 10:37:21AM -0400, Chuck Lever wrote:
> Hi Bruce-
> 
> IMO this series is both safe and effective and thus is ready to merge.

Thanks for the care taken with this series....

I'll queue it up for 4.8 and stable, unless there's objections.

--b.

> 
> Alexey reports:
> 
> @ All 500 nfslock test runs passed, also run other related NFS tests with 
> @ different configurations, as a result they passed as well. 
> 
> 
> Changes since v3:
> - Add Tested-by tags
> 
> Changes since v2:
> - Move NFS4_LOCK_STID arm into a helper, for clarity
> - Add more detail to patch description
> - Add Jeff's patch to fix similar race in nfsd4_lock
> 
> Changes since v1:
> - Use s->sc_count to preserve stateid while cl_lock is dropped
> 
> ---
> 
> Chuck Lever (1):
>       nfsd: Fix race between FREE_STATEID and LOCK
> 
> Jeff Layton (1):
>       nfsd: don't return an unhashed lock stateid after taking mutex
> 
> 
>  fs/nfsd/nfs4state.c |   65 ++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 48 insertions(+), 17 deletions(-)
> 
> --
> Chuck Lever