Return-Path: Received: from mail-it0-f45.google.com ([209.85.214.45]:37580 "EHLO mail-it0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933869AbcIWSZE (ORCPT ); Fri, 23 Sep 2016 14:25:04 -0400 Received: by mail-it0-f45.google.com with SMTP id 186so23439034itf.0 for ; Fri, 23 Sep 2016 11:25:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Olga Kornievskaia Date: Fri, 23 Sep 2016 14:25:03 -0400 Message-ID: Subject: Re: reuse of slot and seq# when RPC was interrupted To: Trond Myklebust Cc: List Linux NFS Mailing Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Sep 23, 2016 at 2:08 PM, Trond Myklebust wrote: > >> On Sep 23, 2016, at 13:59, Olga Kornievskaia wrote: >> >> On Fri, Sep 23, 2016 at 1:45 PM, Trond Myklebust >> wrote: >>> >>>> On Sep 23, 2016, at 13:40, Olga Kornievskaia wrote: >>>> >>>> If we instead bump the sequence number in the case of interrupted and = do: >>> >>> You have no guarantees that the server has seen and processed the opera= tion. >> >> That is correct, i have tested the patch and made server never to >> receive the operation and client have an interrupted slot. On the next >> operation the server will complain back with SEQ_MISORDERED. Client >> can recover from this operation. Client can not recover from "Remote >> EIO=E2=80=9D. >> > > Why not? When XDR layer returns EREMOTEIO it's not handled by the NFS error recovery (are you suggesting we should?) and returns that to the application.