Return-Path: Received: from mx144.netapp.com ([216.240.21.25]:36280 "EHLO mx144.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932181AbcKGPoT (ORCPT ); Mon, 7 Nov 2016 10:44:19 -0500 Subject: Re: [PATCH] net/netfiliter: Fix used uninitialized warn in ip_vs_proc_sync_conn() To: Shuah Khan , References: <20161107154114.26803-1-shuahkh@osg.samsung.com> <20161107154114.26803-3-shuahkh@osg.samsung.com> CC: , From: Anna Schumaker Message-ID: <15645b18-f0ec-81f5-61ed-da8c141e5110@Netapp.com> Date: Mon, 7 Nov 2016 10:44:10 -0500 MIME-Version: 1.0 In-Reply-To: <20161107154114.26803-3-shuahkh@osg.samsung.com> Content-Type: text/plain; charset="utf-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Shuah, On 11/07/2016 10:41 AM, Shuah Khan wrote: > Fix the following warn: > > net/netfilter/ipvs/ip_vs_sync.c: In function ‘ip_vs_proc_sync_conn’: > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.init_seq’ may be used uninitialized in this function [-Wmaybe-uninitialized] > struct ip_vs_sync_conn_options opt; > ^~~ > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.delta’ may be used uninitialized in this function [-Wmaybe-uninitialized] > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.previous_delta’ may be used uninitialized in this function [-Wmaybe-uninitialized] > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).init_seq’ may be used uninitialized in this function [-Wmaybe-uninitialized] > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).delta’ may be used uninitialized in this function [-Wmaybe-uninitialized] > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).previous_delta’ may be used uninitialized in this function [-Wmaybe-uninitialized] Are you sure you put the right commit message on this patch? The message describes a warning in ip_vs_sync.c, but the patch is for nfs4session.c. Thanks, Anna > > Signed-off-by: Shuah Khan > --- > fs/nfs/nfs4session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfs/nfs4session.c b/fs/nfs/nfs4session.c > index b629730..68e700e 100644 > --- a/fs/nfs/nfs4session.c > +++ b/fs/nfs/nfs4session.c > @@ -196,7 +196,7 @@ static int nfs4_slot_get_seqid(struct nfs4_slot_table *tbl, u32 slotid, > static bool nfs4_slot_seqid_in_use(struct nfs4_slot_table *tbl, > u32 slotid, u32 seq_nr) > { > - u32 cur_seq; > + u32 cur_seq = 0; > bool ret = false; > > spin_lock(&tbl->slot_tbl_lock); >