Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:56211 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbcKRObM (ORCPT ); Fri, 18 Nov 2016 09:31:12 -0500 From: Trond Myklebust To: NeilBrown CC: List Linux NFS Mailing Subject: Re: [PATCH] Revert "SUNRPC: xs_sock_mark_closed() does not need to trigger socket autoclose" Date: Fri, 18 Nov 2016 14:31:03 +0000 Message-ID: References: <87a8gtpgw4.fsf@notabene.neil.brown.name> <87d1lhml90.fsf@notabene.neil.brown.name> In-Reply-To: <87d1lhml90.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: DQo+IE9uIEF1ZyA5LCAyMDE2LCBhdCAyMjowNSwgTmVpbEJyb3duIDxuZWlsYkBzdXNlLmNvbT4g d3JvdGU6DQo+IA0KPiBPbiBUaHUsIEF1ZyAwNCAyMDE2LCBUcm9uZCBNeWtsZWJ1c3Qgd3JvdGU6 DQo+IA0KPj4+IE9uIEF1ZyAzLCAyMDE2LCBhdCAxOTozMywgTmVpbEJyb3duIDxuZWlsYkBzdXNl LmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4gDQo+Pj4gVGhpcyByZXZlcnRzIGNvbW1pdCA0YjBhYjUx ZGIzMmViYTBmNDhiNzYxODI1NDc0MmYxNDMzNjRhMjhkLg0KPj4+IA0KPj4+IFRoaXMgY2hhbmdl IGNhdXNlcyAncnBjLm5mc2QnIHRvIGhhbmcgZm9yIGxvbmcgdGltZSBpZiBycGNiaW5kIGlzIG5v dA0KPj4+IGF2YWlsYWJsZS4NCj4+PiBJZg0KPj4+ICAtLW5vLW5mcy12ZXJzaW9uIDIgLS1uby1u ZnMtdmVyc2lvbiAzDQo+Pj4gaXMgZ2l2ZW4sIHRoZSBkZWxheSBpcyBhYm91dCA2LjUgbWludXRl cy4gIFdoZW4gdHJ5aW5nIHRvIHJlZ2lzdGVyDQo+Pj4gYWxsIHZlcnNpb25zLCB0aGUgZGVsYXkg aXMgb3ZlciBoYWxmIGFuIGhvdXIuDQo+Pj4gQmVmb3JlIHRoaXMgY29tbWl0LCBhbmQgYWZ0ZXIg cmV2ZXJ0aW5nIGl0LCBuZnNkIGZhaWxzICh3aGVuIHYzIGlzDQo+Pj4gcmVxdWVzdGVkKSBvciBz dWNjZWVkcyAod2hlbiBvbmx5IHY0IGlzIHJlcXVlc3RlZCkgaW1tZWRpYXRlbHkuDQo+Pj4gDQo+ Pj4gU2lnbmVkLW9mZi1ieTogTmVpbEJyb3duIDxuZWlsYkBzdXNlLmNvbT4NCj4+PiAtLS0NCj4+ PiBuZXQvc3VucnBjL3hwcnRzb2NrLmMgfCAxICsNCj4+PiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKykNCj4+PiANCj4+PiBkaWZmIC0tZ2l0IGEvbmV0L3N1bnJwYy94cHJ0c29jay5jIGIv bmV0L3N1bnJwYy94cHJ0c29jay5jDQo+Pj4gaW5kZXggMTExNzY3YWIxMjRhLi4yYTkzODA1NWU5 NWIgMTAwNjQ0DQo+Pj4gLS0tIGEvbmV0L3N1bnJwYy94cHJ0c29jay5jDQo+Pj4gKysrIGIvbmV0 L3N1bnJwYy94cHJ0c29jay5jDQo+Pj4gQEAgLTc5NSw2ICs3OTUsNyBAQCBzdGF0aWMgdm9pZCB4 c19zb2NrX21hcmtfY2xvc2VkKHN0cnVjdCBycGNfeHBydCAqeHBydCkNCj4+PiAJeHNfc29ja19y ZXNldF9jb25uZWN0aW9uX2ZsYWdzKHhwcnQpOw0KPj4+IAkvKiBNYXJrIHRyYW5zcG9ydCBhcyBj bG9zZWQgYW5kIHdha2UgdXAgYWxsIHBlbmRpbmcgdGFza3MgKi8NCj4+PiAJeHBydF9kaXNjb25u ZWN0X2RvbmUoeHBydCk7DQo+Pj4gKwl4cHJ0X2ZvcmNlX2Rpc2Nvbm5lY3QoeHBydCk7DQo+Pj4g fQ0KPj4+IA0KPj4gDQo+PiBJZiB0aGVyZSBpcyBhbiBvdXRzdGFuZGluZyByZXF1ZXN0LCB0aGVu IF90aGF0XyBpcyBzdXBwb3NlZCB0byByZWRyaXZlIHRoZSBjb25uZWN0aW9uLiBXaHkgaXMgdGhl IHhwcnRfZGlzY29ubmVjdF9kb25lKCkgbm90IGZ1bmN0aW9uaW5nIGFzIHBlciB0aGUgY29tbWVu dCBhYm92ZSBpdD8NCj4gDQo+IEkgbWFkZSBzb21lIHRpbWUgdG8gbG9vayBhdCB0aGlzIGFuZCBo YXZlIGEgc29tZXdoYXQgY2xlYXJlcg0KPiB1bmRlcnN0YW5kaW5nLg0KPiANCj4gVGhlIHJwY2Jp bmQgY29kZSBtYWtlcyBhYm91dCAyNCByZXF1ZXN0cywgaW5jbHVkZSBOVUxMIHBpbmdzLCBVTlNF VA0KPiByZXF1ZXN0cyB0byBjbGVhciBhbnkgb2xkIHJlZ2lzdHJhdGlvbnMsIGFuZCBTRVQgcmVx dWVzdHMuDQo+IA0KPiBUaGUgZmlyc3QgKGEgTlVMTCkgZmFpbHMgaW1tZWRpYXRlbHkgZHVlIHRv IEVDT05OUkVGVVNFRC4gIE90aGVycyBhcmVuJ3QNCj4gZXZlbiBhdHRlbXB0ZWQgZm9yIGEgZ3Jv d2luZyBudW1iZXIgb2Ygc2Vjb25kcyBiZWNhdXNlIHhzX2Nvbm5lY3QoKQ0KPiBmaW5kcyB0aGF0 IHRyYW5zcG9ydC0+c29jayBpcyBub3QgTlVMTCwgc28gaXQgZGVsYXlzIGJlZm9yZSB0cnlpbmcu DQo+IE9uY2UgaXQgdHJpZXMsIGl0IGZhaWxlZCBpbW1lZGlhdGVseSBhbmQgd2UgbW92ZSBvbiB0 byB0aGUgbmV4dCByZXF1ZXN0Lg0KPiANCj4gdHJhbnNwb3J0LT5zb2NrIGlzIHNldCB0byBOVUxM IGJ5IHhzX3Jlc2V0X3RyYW5zcG9ydCgpIHdoaWNoIHhzX2Nvbm5lY3QoKSBjYWxscw0KPiBhcyBw YXJ0IG9mIHRoZSB0aGUgdGltZW91dCwgYnV0IC0+cmVlc3RhYmxpc2hfdGltZW91dCBpcyBub3Qg cmVzZXQuDQo+IFRoZSBuZXh0IHRpbWUgeHNfY29ubmVjdCBpcyBjYWxsZWQsIC0+c29jayB3aWxs IGJlIG5vbi1OVUxMIGFnYWluIGFzDQo+IHRyYW5zcG9ydC0+cmVlc3RhYmxpc2hfdGltZW91dCB3 aWxsIGJlIGxvbmdlci4NCj4gDQo+IHRyYW5zcG9ydC0+c29jayBpcyBvbmx5IHNldCB0byBOVUxM ICpiZWZvcmUqIHRoZSB0ZXN0IGluIHhzX2Nvbm5lY3QoKSBieSBhDQo+IGNhbGwgdG8geHNfY2xv c2UoKSBvciAtPmNsb3NlKCkuICBCdXQgbm90aGluZyBpbiB0cmlnZ2VyaW5nIHRoaXMuDQo+IA0K PiB4c19zb2NrX21hcmtfY2xvc2VkKCkgY3VycmVudGx5IGRvZXNuJ3QgYWN0dWFsbHkgbWFyayB0 aGUgc29ja2V0IGFzDQo+IGNsb3NlZCAoWFBSVF9DTE9TRV9XQUlUSU5HKSwgb3IgY2xvc2UgaXQg ZGlyZWN0bHkuDQo+IA0KPiBzdGF0aWMgdm9pZCB4c19zb2NrX21hcmtfY2xvc2VkKHN0cnVjdCBy cGNfeHBydCAqeHBydCkNCj4gew0KPiAJeHNfc29ja19yZXNldF9jb25uZWN0aW9uX2ZsYWdzKHhw cnQpOw0KPiAJLyogTWFyayB0cmFuc3BvcnQgYXMgY2xvc2VkIGFuZCB3YWtlIHVwIGFsbCBwZW5k aW5nIHRhc2tzICovDQo+IAl4cHJ0X2Rpc2Nvbm5lY3RfZG9uZSh4cHJ0KTsNCj4gfQ0KPiANCj4g eHNfc29ja19yZXNldF9jb25uZWN0aW9uX2ZsYWdzKCkgY2xlYXJzIFhQUlRfQ0xPU0VfV0FJVElO RywNCj4gWFBSVF9DTE9TSU5HLCBhbmQgWFBSVF9TT0NLX0RBVEFfUkVBRFksIGFuZCBhZGRzIHNv bWUgbWVtb3J5IGJhcnJpZXIuDQo+IA0KPiB4cHJ0X2Rpc2Nvbm5lY3RfZG9uZSgpIGNsZWFycyBY UFJUX0NPTk5FQ1RFRCBhbmQgd2FrZXMgdXAgdGhlIHRhc2suDQo+IA0KPiBTbyBub25lIG9mIHRo aXMgd2lsbCAiTWFyayB0cmFuc3BvcnQgYXMgY2xvc2VkIiBsaWtlIHRoZSBjb21tZW50DQo+IHN1 Z2dlc3RzLiAgVGhleSBqdXN0IG1hcmsgaXQgYXMgZGlzY29ubmVjdGVkLg0KPiB4c19zb2NrX3Jl c2V0X2Nvbm5lY3Rpb25fZmxhZ3MoKSBldmVuICpjbGVhcnMqIFhQUlRfQ0xPU0VfV0FJVElORywg d2hpY2gNCj4gd2UgcmVhbGx5IHdhbnQgdG8gYmUgc2V0Lg0KPiANCj4gVGhlIGNvbW1pdCBzYWlk Og0KPiANCj4gICAgVW5kZXIgYWxsIGNvbmRpdGlvbnMsIGl0IHNob3VsZCBiZSBxdWl0ZSBzdWZm aWNpZW50IGp1c3QgdG8gbWFyaw0KPiAgICB0aGUgc29ja2V0IGFzIGRpc2Nvbm5lY3RlZC4gSXQg d2lsbCB0aGVuIGJlIGNsb3NlZCBieSB0aGUNCj4gICAgdHJhbnNwb3J0IHNodXRkb3duIG9yIHJl Y29ubmVjdCBjb2RlLg0KPiANCj4gVGhlICJyZWNvbm5lY3QgY29kZSIgaXMgcHJlc3VtYWJseSB4 cHJ0X2Nvbm5lY3QoKT8gIFRoaXMgd2lsbCBjbG9zZSB0aGUNCj4gc29ja2V0IGlmIFhQUlRfQ0xP U0VfV0FJVCBpcyBzZXQuLCBidXQgbm90IGlmIHRoZSBzb2NrZXQgaXMgbWFya2VkIGFzDQo+IGRp c2Nvbm5lY3RlZC4gIFdoZW4gbWFya2VkIGFzIGRpc2Nvbm5lY3RlZCwgaXQgdHJpZXMgdG8gcmVj b25uZWN0IC0NCj4gd2hpY2ggaW5jdXJzIGEgdGltZW91dC4NCj4gDQo+IFRoZSAidHJhbnNwb3J0 IHNodXRkb3duIiBjb2RlIGlzIHByZXN1bWFibHkgeHBydF9kZXN0cm95KCk/ICBZZXMsIHRoYXQN Cj4gd291bGQgY2xvc2UgdGhlIHNvY2tldCwgYnV0IHRoYXQgZG9lc24ndCBzdHJhaWdodCBhd2F5 LiAgVGhlIHJwY2JpbmQNCj4gY2xpZW50IGNhbiB0cnkgMTAgVU5TRVQgY2FsbHMgYmVmb3JlIGRl c3Ryb3lpbmcgdGhlIHRyYW5zcG9ydC4NCj4gDQo+IA0KPiBJdCBpcyBwb3NzaWJsZSB0aGF0IF9f c3ZjX3VucmVnaXN0ZXIgc2hvdWxkIHJldHVybiBhbiBlcnJvciBzbyB0aGF0DQo+IHN2Y191bnJl Z2lzdGVyKCkgY2FuIGFib3J0IHRoZSBsb29wIG9uIGVycm9yLiAgVGhhdCB3b3VsZCByZWR1Y2Ug dGhlDQo+IHRpbWVvdXRzIHRvIHNvbWUgZXh0ZW50LCBidXQgbm90IGNvbXBsZXRlbHkgYXMgd2Ug d291bGQgc3RpbGwgZ2V0IGENCj4gdGltZW91dCB3aGVuIHRyeWluZyB0byByZWdpc3Rlci4gIEl0 IG1pZ2h0IG1ha2Ugc2Vuc2UgdGhhdCBpZiB0aGUNCj4gc3ZjX3VucmVnaXN0ZXIoKSBpbiBzdmNf cnBjYl9zZXR1cCgpIGZhaWxzIGR1ZSB0byBFQ09OTlJFRlVTRUQsIHRoZW4gaXQNCj4gc2hvdWxk IGZhaWwgc28gd2UgbmV2ZXIgZXZlbiB0cnkgdG8gcmVnaXN0ZXIuICBQbHVtYmluZyB0aGF0IHN0 YXR1cw0KPiB0aHJvdWdoIG5mc2Qgc28gdGhhdCBpdCBkb2Vzbid0IGFib3J0IGluIHRoZSBWNC1v bmx5IGNhc2Ugd2hlbiBycGNiaW5kDQo+IGlzbid0IGF2YWlsYWJsZSBjb3VsZCBiZSBkb25lLCBi dXQgc2VlbXMgbGlrZSBhIGxvdCBvZiB3b3JrIGZvciBsaXR0bGUgZ2Fpbi4NCj4gDQo+IEFsc28s IHRoZSBlcnJvciB0aGF0IGNvbWVzIHRocm91Z2ggdG8gX19zdmNfdW5yZWdpc3RlciBpcyAiLUVB R0FJTiINCj4gcmF0aGVyIHRoZW4gLUVDT05OUkVGVVNFRC4NCj4gDQo+IEkgdGhpbmsgdGhhdCB0 aGUgZWFzaWVzdCBzb2x1dGlvbiBpcyB0byBtYWtlIHN1cmUgcmVjb25uZWN0aW9uIGF0dGVtcHRz DQo+IG9uIGFuIFJQQ19JU19TT0ZUQ09OTiB0YXNrcyBkbyBub3QgdHJpZ2dlciBhIGRlbGF5IGlu IHhzX2Nvbm5lY3QoKS4NCj4gY2FsbF9jb25uZWN0X3N0YXR1cygpIGFscmVhZHkgYWRkcyBhIDNz ZWNvbmQgZGVsYXkgZm9yIG90aGVyIHRhc2tzLCBzbw0KPiBzaW1wbHkgZm9yY2luZyBhIGNsb3Nl IGluIHhzX3NvY2tfbWFya2VkX2Nsb3NlKCkgc2hvdWxkIGJlIHN1ZmZpY2llbnQuDQo+IFRoZSBy ZXZlcnQgSSBwb3N0ZWQgd291bGQgZG8gdGhhdCwgb3Igd2UgY291bGQganVzdCBhZGQNCj4gDQo+ IAlzZXRfYml0KFhQUlRfQ0xPU0VfV0FJVCwgJnhwcnQtPnN0YXRlKTsNCj4gDQo+IHNvIHRoYXQg dGhlIGNvbW1lbnQgd291bGQgYmUgY29ycmVjdC4gIFRoYXQgaXMgc3VmZmljaWVudC4NCj4gDQo+ IEFub3RoZXIgYXBwcm9hY2ggd2hpY2ggd29ya3MgaXM6DQo+IGRpZmYgLS1naXQgYS9uZXQvc3Vu cnBjL2NsbnQuYyBiL25ldC9zdW5ycGMvY2xudC5jDQo+IGluZGV4IDdmNzlmYjdkYzZhMC4uZjgw YjEzNWI0ODMwIDEwMDY0NA0KPiAtLS0gYS9uZXQvc3VucnBjL2NsbnQuYw0KPiArKysgYi9uZXQv c3VucnBjL2NsbnQuYw0KPiBAQCAtMTkzNiw4ICsxOTM2LDEwIEBAIGNhbGxfY29ubmVjdF9zdGF0 dXMoc3RydWN0IHJwY190YXNrICp0YXNrKQ0KPiAJY2FzZSAtRUFERFJJTlVTRToNCj4gCWNhc2Ug LUVOT0JVRlM6DQo+IAljYXNlIC1FUElQRToNCj4gLQkJaWYgKFJQQ19JU19TT0ZUQ09OTih0YXNr KSkNCj4gKwkJaWYgKFJQQ19JU19TT0ZUQ09OTih0YXNrKSkgew0KPiArCQkJeHBydF9mb3JjZV9k aXNjb25uZWN0KHRhc2stPnRrX3Jxc3RwLT5ycV94cHJ0KTsNCj4gCQkJYnJlYWs7DQo+ICsJCX0N Cj4gCQkvKiByZXRyeSB3aXRoIGV4aXN0aW5nIHNvY2tldCwgYWZ0ZXIgYSBkZWxheSAqLw0KPiAJ CXJwY19kZWxheSh0YXNrLCAzKkhaKTsNCj4gCWNhc2UgLUVBR0FJTjoNCj4gDQo+IHNvIHRoYXQg d2UgZm9yY2UgYSBkaXNjb25uZWN0IHByZWNpc2VseSB3aGVuIGEgY29ubmVjdGlvbiBhdHRlbXB0 IGZhaWxzDQo+IG9uIGEgU09GVENPTk4gdGFzay4NCj4gDQo+IFdoaWNoIG9mIHRoZXNlIHNvbHV0 aW9ucyBkbyB5b3UgcHJlZmVyPw0KDQoNCkluc3RlYWQgb2YgdGhlIGFib3ZlLCBjb3VsZCB3ZSBy YXRoZXIgbG9vayBhdCBhZGRpbmcgYSBjYWxsIHRvIHhwcnRfY29uZGl0aW9uYWxfZGlzY29ubmVj dCgpIHRvIGVuc3VyZSB0aGF0IHdlIGRvbuKAmXQga2VlcCBkaXNjb25uZWN0aW5nIG11bHRpcGxl IHRpbWVzPyBJdCBtZWFucyB3ZeKAmWQgaGF2ZSB0byBzZXQgcmVxLT5ycV9jb25uZWN0X2Nvb2tp ZSBpbiB4cHJ0X2Nvbm5lY3QoKSBiZWZvcmUgc2xlZXBpbmcgb24geHBydC0+cGVuZGluZywgYnV0 IEkgZG9u4oCZdCB0aGluayB0aGF0IGlzIGEgbWFqb3IgaW1wb3NpdGlvbi4NCg0KSSBhbHNvIHRo aW5rIHdlIG1pZ2h0IG5vdCB3YW50IHRvIG1ha2UgdGhhdCBjYWxsIGNvbmRpdGlvbmFsIG9uIFJQ Q19JU19TT0ZUQ09OTi4NCg0KDQo=