Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:56874 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755681AbcK3OYU (ORCPT ); Wed, 30 Nov 2016 09:24:20 -0500 Date: Wed, 30 Nov 2016 09:24:12 -0500 From: "J. Bruce Fields" To: Frank Filz Cc: "'Tom Haynes'" , "'Linux NFS Mailing list'" Subject: Re: [PATCH pynfs 00/12] Flex File support Message-ID: <20161130142412.GA18463@parsley.fieldses.org> References: <1480228001-64821-1-git-send-email-loghyr@primarydata.com> <20161128163321.GB30805@parsley.fieldses.org> <012c01d24a9a$92ff7580$b8fe6080$@mindspring.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <012c01d24a9a$92ff7580$b8fe6080$@mindspring.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Nov 29, 2016 at 03:44:48PM -0800, Frank Filz wrote: > > > > -----Original Message----- > > From: linux-nfs-owner@vger.kernel.org [mailto:linux-nfs- > > owner@vger.kernel.org] On Behalf Of J. Bruce Fields > > Sent: Monday, November 28, 2016 8:33 AM > > To: Tom Haynes > > Cc: Linux NFS Mailing list > > Subject: Re: [PATCH pynfs 00/12] Flex File support > > > > On Sat, Nov 26, 2016 at 10:26:29PM -0800, Tom Haynes wrote: > > > I wanted to add client support for the flex file layout. > > > > > > Note, I did not add pynfs as a flag because I didn't want to mess up > > > with any existing uses of it. > > > > > > The other major change here is in closing all opened files and > > > destroying all clientids. With all the tests which run against my > > > server, there are no longer any open files. There are however 11 > > > clientids remaining. > > > > > > I will track those down. > > > > > > fwiw - these are in my staging branch at > > > git://linux-nfs.org/~loghyr/pynfs.git > > > > Thanks! I'll try these and take a look. > > > > How did you notice all the leftover state? I run with a pretty short > lease time > > (to speed testing), so I guess the leftover state must expire too quickly > to > > cause me problems. > > > > Anyway it's good to have that cleaned up. > > Not closing files and releasing clientids at least in the 4.0 tests has > actually shaken out bugs in Ganesha... > > But maybe that kind of thing should be an explicit test, create lots of > clientids/sessions, and then wait for them all to expire and see if the > server can handle all the activity. Yes, probably so. I seem to recall this not being the first time this has caused problems for people with test scripts that try to unmount immediately after running pynfs. --b.