Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:46645 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345AbcLKSf2 (ORCPT ); Sun, 11 Dec 2016 13:35:28 -0500 Date: Sun, 11 Dec 2016 10:34:26 -0800 From: "Darrick J. Wong" To: Amir Goldstein Cc: Anna Schumaker , fstests , linux-nfs@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v4 0/5] Add copy_file_range() tests Message-ID: <20161211183426.GE25841@birch.djwong.org> References: <20161208184909.23321-1-Anna.Schumaker@Netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Sun, Dec 11, 2016 at 11:03:50AM +0200, Amir Goldstein wrote: > On Thu, Dec 8, 2016 at 8:49 PM, Anna Schumaker > wrote: > > These tests exercise the copy_file_range() system call, and check copying > > data to both a new file and overwriting data inside an existing file. > > > > Hi Anna, > > Both dedup and reflink have some generic tests to check for invalid cases > generic/{157,158}. > I wonder if there are any other dedup/reflink tests that should be > duplicated for copy_range. Darrick? Yes, feel free to borrow from g/157. :) > I also wonder if it would make sense to "deduplicate" some of these test > to repeat the same relevant checks for all 3 methods. You could refactor them but for two tests (dedupe is its own weird animal) I don't think it's worth the effort. --D > > > > The last patch is a duplicate of a patch I already submitted for the > > xfs_io utility. It adds in fixes for the 'copy_range' command so error > > checking can work and so some copies won't loop forever. > > > > Thanks, > > Anna > > > > Anna Schumaker (5): > > generic/392: Add copy to new file test > > generic/393: Add small copies to new file test > > generic/394: Add copy test that overwrites data > > generic/395: Add a copy test for overwriting small amounts of data > > generic/396: Add a copy test for invalid input > > > > common/rc | 6 +++ > > tests/generic/392 | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/392.out | 26 +++++++++++++ > > tests/generic/393 | 83 ++++++++++++++++++++++++++++++++++++++++ > > tests/generic/393.out | 16 ++++++++ > > tests/generic/394 | 100 +++++++++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/394.out | 17 +++++++++ > > tests/generic/395 | 87 ++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/395.out | 17 +++++++++ > > tests/generic/396 | 68 +++++++++++++++++++++++++++++++++ > > tests/generic/396.out | 8 ++++ > > tests/generic/group | 5 +++ > > 12 files changed, 535 insertions(+) > > create mode 100755 tests/generic/392 > > create mode 100644 tests/generic/392.out > > create mode 100755 tests/generic/393 > > create mode 100644 tests/generic/393.out > > create mode 100755 tests/generic/394 > > create mode 100644 tests/generic/394.out > > create mode 100755 tests/generic/395 > > create mode 100644 tests/generic/395.out > > create mode 100644 tests/generic/396 > > create mode 100644 tests/generic/396.out > > > > -- > > 2.10.2 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe fstests" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html