Return-Path: From: Trond Myklebust To: Jeffrey Layton CC: Benjamin Coddington , Anna Schumaker , Linux NFS Mailing List Subject: Re: [PATCH] NFS: nfs_rename() handle -ERESTARTSYS dentry left behind Date: Fri, 16 Dec 2016 14:44:26 +0000 Message-ID: References: <11625082826baa811b3ad5b87e1e6e712c6e582d.1481813137.git.bcodding@redhat.com> <7D53DC24-3DA9-40BB-BF6E-6DF03A7A0852@redhat.com> <1481898915.2639.5.camel@poochiereds.net> In-Reply-To: <1481898915.2639.5.camel@poochiereds.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 List-ID: DQo+IE9uIERlYyAxNiwgMjAxNiwgYXQgMDk6MzUsIEplZmYgTGF5dG9uIDxqbGF5dG9uQHBvb2No aWVyZWRzLm5ldD4gd3JvdGU6DQo+IA0KPiBPbiBGcmksIDIwMTYtMTItMTYgYXQgMTQ6MjMgKzAw MDAsIFRyb25kIE15a2xlYnVzdCB3cm90ZToNCj4+PiANCj4+PiBPbiBEZWMgMTYsIDIwMTYsIGF0 IDA2OjA5LCBCZW5qYW1pbiBDb2RkaW5ndG9uIDxiY29kZGluZ0ByZWRoYXQuY29tPiB3cm90ZToN Cj4+PiANCj4+PiBPbiAxNSBEZWMgMjAxNiwgYXQgMTc6MzgsIFRyb25kIE15a2xlYnVzdCB3cm90 ZToNCj4+PiANCj4+Pj4gDQo+Pj4+PiANCj4+Pj4+IE9uIERlYyAxNSwgMjAxNiwgYXQgMDk6NDgs IEJlbmphbWluIENvZGRpbmd0b24gPGJjb2RkaW5nQHJlZGhhdC5jb20+IHdyb3RlOg0KPj4+Pj4g DQo+Pj4+PiBBbiBpbnRlcnJ1cHRlZCByZW5hbWUgd2lsbCBsZWF2ZSB0aGUgb2xkIGRlbnRyeSBi ZWhpbmQgaWYgdGhlIHJlbmFtZQ0KPj4+Pj4gc3VjY2VlZHMuICBGaXggdGhpcyBieSBmb3JjaW5n IGEgbG9va3VwIHRoZSBuZXh0IHRpbWUgdGhyb3VnaA0KPj4+Pj4gLT5kX3JldmFsaWRhdGUuDQo+ Pj4+PiANCj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEJlbmphbWluIENvZGRpbmd0b24gPGJjb2RkaW5n QHJlZGhhdC5jb20+DQo+Pj4+PiAtLS0NCj4+Pj4+IGZzL25mcy9kaXIuYyB8IDE0ICsrKysrKysr KysrKy0tDQo+Pj4+PiAxIGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkNCj4+Pj4+IA0KPj4+Pj4gZGlmZiAtLWdpdCBhL2ZzL25mcy9kaXIuYyBiL2ZzL25mcy9k aXIuYw0KPj4+Pj4gaW5kZXggNWYxYWY0Y2QxYTMzLi41ZDQwOTYxNmY3N2UgMTAwNjQ0DQo+Pj4+ PiAtLS0gYS9mcy9uZnMvZGlyLmMNCj4+Pj4+ICsrKyBiL2ZzL25mcy9kaXIuYw0KPj4+Pj4gQEAg LTIxMDAsMTQgKzIxMDAsMjQgQEAgaW50IG5mc19yZW5hbWUoc3RydWN0IGlub2RlICpvbGRfZGly LCBzdHJ1Y3QgZGVudHJ5ICpvbGRfZGVudHJ5LA0KPj4+Pj4gCQlkX3JlaGFzaChyZWhhc2gpOw0K Pj4+Pj4gCXRyYWNlX25mc19yZW5hbWVfZXhpdChvbGRfZGlyLCBvbGRfZGVudHJ5LA0KPj4+Pj4g CQkJbmV3X2RpciwgbmV3X2RlbnRyeSwgZXJyb3IpOw0KPj4+Pj4gLQlpZiAoIWVycm9yKSB7DQo+ Pj4+PiArDQo+Pj4+PiArCXN3aXRjaCAoZXJyb3IpIHsNCj4+Pj4+ICsJY2FzZSAwOg0KPj4+Pj4g CQlpZiAobmV3X2lub2RlICE9IE5VTEwpDQo+Pj4+PiAJCQluZnNfZHJvcF9ubGluayhuZXdfaW5v ZGUpOw0KPj4+Pj4gCQlkX21vdmUob2xkX2RlbnRyeSwgbmV3X2RlbnRyeSk7DQo+Pj4+PiAJCW5m c19zZXRfdmVyaWZpZXIobmV3X2RlbnRyeSwNCj4+Pj4+IAkJCQkJbmZzX3NhdmVfY2hhbmdlX2F0 dHJpYnV0ZShuZXdfZGlyKSk7DQo+Pj4+PiAtCX0gZWxzZSBpZiAoZXJyb3IgPT0gLUVOT0VOVCkN Cj4+Pj4+ICsJCWJyZWFrOw0KPj4+Pj4gKwljYXNlIC1FTk9FTlQ6DQo+Pj4+PiAJCW5mc19kZW50 cnlfaGFuZGxlX2Vub2VudChvbGRfZGVudHJ5KTsNCj4+Pj4+ICsJCWJyZWFrOw0KPj4+Pj4gKwlj YXNlIC1FUkVTVEFSVFNZUzoNCj4+Pj4+ICsJCS8qIFRoZSByZXN1bHQgb2YgdGhlIHJlbmFtZSBp cyB1bmtub3duLiBQbGF5IGl0IHNhZmUgYnkNCj4+Pj4+ICsJCSAqIGZvcmNpbmcgYSBuZXcgbG9v a3VwICovDQo+Pj4+PiArCQluZnNfZm9yY2VfbG9va3VwX3JldmFsaWRhdGUob2xkX2Rpcik7DQo+ Pj4+PiArCQluZnNfZm9yY2VfbG9va3VwX3JldmFsaWRhdGUobmV3X2Rpcik7DQo+Pj4+PiArCX0N Cj4+Pj4gDQo+Pj4+IERvZXNu4oCZdCB0aGlzIGVycm9yIGhhbmRsaW5nIGJlbG9uZyBpbiBuZnNf YXN5bmNfcmVuYW1lX2RvbmUoKSwgb3IgcG9zc2libHkgaW4gaXRzIOKAnGRhdGEtPmNvbXBsZXRl KCnigJ0gY2FsbGJhY2s/IFRoZXJlIGlzbuKAmXQgbXVjaCBwb2ludCBpbiBmb3JjaW5nIGEgbmV3 IGxvb2t1cCB1bnRpbCB3ZSBrbm93IHRoZSBSUEMgY2FsbCBoYXMgcnVuIGl0cyBjb3Vyc2UuDQo+ Pj4gDQo+Pj4gVGhhdCB3b3VsZCBiZSBtb3JlIGNvcnJlY3QsIGhvd2V2ZXIgaWYgbW92ZWQgdGhl cmUsIHdlJ2QgYmUgZm9yY2luZyBhIGxvb2t1cCBhZnRlciBldmVyeSByZW5hbWUsIG5vdCBqdXN0 IGEgcmVuYW1lIHRoYXQgd2FzIHNpZ25hbGVkLiAgSXMgaXQgd29ydGggdHJ5aW5nIHRvIGZpbmQg YSB3YXkgdG8gaW5mb3JtIHRob3NlIGZ1bmN0aW9ucyB0aGF0IHRoZSB3YWl0IHdhcyBpbnRlcnJ1 cHRlZD8NCj4+PiANCj4+IA0KPj4gVGhlcmUgYXJlIGFscmVhZHkgcHJlY2VkZW50cyBmb3IgdGhp cy4gTG9vaywgZm9yIGluc3RhbmNlLCBhdCBob3cgdGhlIGRhdGEtPmNhbmNlbGxlZCBmbGFnIGlu dGVyb3BlcmF0ZXMgYmV0d2VlbiBuZnM0X3J1bl9vcGVuX3Rhc2soKSBhbmQgDQo+PiBuZnM0X29w ZW5fcmVsZWFzZSgpIHRvIHRyaWdnZXIgc3RhdGUgcmVjb3ZlcnkgKGJ5IGlzc3VpbmcgYSBjbG9z ZSkgaWYgdGhlIFJQQyBjYWxsIHdhcyBjb21wbGV0ZWQsIGJ1dCB0aGUgdXNlciBpbnRlcnJ1cHRl ZCB0aGUgb3BlcmF0aW9uLg0KPj4gDQo+PiBDaGVlcnMNCj4+ICBUcm9uZA0KPiANCj4gVGhlcmUg aXMgdGhlIHRpbWluZyB0byBjb25zaWRlciBoZXJlIGFzIHdlbGwuIE9uY2UgeW91IHJldHVybiBm cm9tIHRoaXMNCj4gZnVuY3Rpb24gdGhlIHZmcyBpcyBnb2luZyB0byB1bmxvY2sgZXZlcnl0aGlu ZyB3aXRob3V0IGRvaW5nIHRoZSBkX21vdmUuDQo+IA0KPiBJcyBpdCBiZXR0ZXIgdG8gbWFyayB0 aGUgZGlyZWN0b3JpZXMgZm9yIHJldmFsaWRhdGlvbiBhdCB0aGF0IHBvaW50LCBvcg0KPiB3aGVu IHRoZSBSRU5BTUUgcmVwbHkgY29tZXMgaW4/IEkgd291bGQgdGhpbmsgdGhhdCBtYXJraW5nIGl0 IGZvciByZXZhbA0KPiBpbW1lZGlhdGVseSB3b3VsZCBiZSBiZXN0LiBJcyB0aGVyZSBhbiBhcmd1 bWVudCBmb3Igd2FpdGluZz8NCj4gDQoNClNlZSBhYm92ZS4gSXQgaXMgcG9pbnRsZXNzIHRvIHJl dmFsaWRhdGUgYmVmb3JlIHRoZSByZW5hbWUoKSBoYXMgY29tcGxldGVkLg0KDQo=