Return-Path: Received: from fieldses.org ([173.255.197.46]:49420 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756297AbdABP1m (ORCPT ); Mon, 2 Jan 2017 10:27:42 -0500 Date: Mon, 2 Jan 2017 10:27:41 -0500 From: Bruce James Fields To: Christoph Hellwig Cc: Trond Myklebust , linux-nfs@vger.kernel.org Subject: Re: [nfsv4] RFC 7530: Filehandle of opened file after the REMOVE Message-ID: <20170102152741.GA16526@fieldses.org> References: <20161227144414.GA32002@fieldses.org> <20161229024703.GA21325@fieldses.org> <20161229074830.GA3002@lst.de> <20161229205426.GA389@fieldses.org> <20161230083530.GA26413@lst.de> <20170101135817.GA18418@lst.de> <20170101221025.GA7216@fieldses.org> <20170102084005.GA3471@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170102084005.GA3471@lst.de> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Jan 02, 2017 at 09:40:05AM +0100, Christoph Hellwig wrote: > On Sun, Jan 01, 2017 at 05:10:25PM -0500, Bruce James Fields wrote: > > How do we handle clean shutdown, though? At a minimum a server admin > > needs to be able to e.g. take down the server for an OS upgrade. > > That's going to be a nightmare to implement unfortunately. Ugh. I think it's a requirement; without it: - if we set the flag that allows the client to turn off sillyrename, then users will see a regression (ESTALE after clean shutdowns in situations we previously guaranteed safe). - if we don't set that flag, we don't get to turn off client sillyrename. The only improvement is that we avoid ESTALE after crashes on files unlinked by a different client than held it open. I don't think that's very interesting on its own. --b.