Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:55808 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965231AbdADNnQ (ORCPT ); Wed, 4 Jan 2017 08:43:16 -0500 From: Trond Myklebust To: Nicholas Piggin CC: Andrew Morton , Linux NFS Mailing List , "linux-mm@kvack.org" , "Neil Brown" , Trond Myklebust Subject: Re: [PATCH 1/2] nfs: no PG_private waiters remain, remove waker Date: Wed, 4 Jan 2017 13:43:10 +0000 Message-ID: <0562F017-2963-41E0-BE5B-62A07EC444CD@primarydata.com> References: <20170103182234.30141-1-npiggin@gmail.com> <20170103182234.30141-2-npiggin@gmail.com> In-Reply-To: <20170103182234.30141-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Nick, > On Jan 3, 2017, at 13:22, Nicholas Piggin wrote: >=20 > Since commit 4f52b6bb ("NFS: Don't call COMMIT in ->releasepage()"), > no tasks wait on PagePrivate, so the wake introduced in commit 95905446 > ("NFS: avoid deadlocks with loop-back mounted NFS filesystems.") can > be removed. >=20 > Signed-off-by: Nicholas Piggin > --- > fs/nfs/write.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/fs/nfs/write.c b/fs/nfs/write.c > index b00d53d13d47..006068526542 100644 > --- a/fs/nfs/write.c > +++ b/fs/nfs/write.c > @@ -728,8 +728,6 @@ static void nfs_inode_remove_request(struct nfs_page = *req) > =09=09if (likely(head->wb_page && !PageSwapCache(head->wb_page))) { > =09=09=09set_page_private(head->wb_page, 0); > =09=09=09ClearPagePrivate(head->wb_page); > -=09=09=09smp_mb__after_atomic(); > -=09=09=09wake_up_page(head->wb_page, PG_private); > =09=09=09clear_bit(PG_MAPPED, &head->wb_flags); > =09=09} > =09=09nfsi->nrequests--; > --=20 > 2.11.0 >=20 That looks fine to me. Do you want to push it through the linux-mm path or = do you want me to take it? Cheers Trond Acked-by: Trond Myklebust