Return-Path: Received: from verein.lst.de ([213.95.11.211]:53025 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252AbdBIPqH (ORCPT ); Thu, 9 Feb 2017 10:46:07 -0500 Date: Thu, 9 Feb 2017 16:46:05 +0100 From: Christoph Hellwig To: "J. Bruce Fields" Cc: Christoph Hellwig , linux-nfs@vger.kernel.org Subject: Re: [PATCH] nfsd: don't get =?utf-8?Q?writ?= =?utf-8?Q?e_access_tw=D1=96ce?= in nfsd_setattr Message-ID: <20170209154605.GA16292@lst.de> References: <20170207091244.GA14911@lst.de> <20170208214538.GB17622@fieldses.org> <20170208215038.GA21910@lst.de> <20170208215101.GC17622@fieldses.org> <20170209132516.GA12528@lst.de> <20170209154307.GD17622@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170209154307.GD17622@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Feb 09, 2017 at 10:43:07AM -0500, J. Bruce Fields wrote: > On Thu, Feb 09, 2017 at 02:25:16PM +0100, Christoph Hellwig wrote: > > On Wed, Feb 08, 2017 at 04:51:01PM -0500, J. Bruce Fields wrote: > > > > FYI, Chuck just reported another issue, let's wait for that for now. > > > > I can't really reproduce the issue Chuck reported. So let's get this > > fixup in for now, especially as Linus replied to the thread it was > > reported in and asked for it. > > I can't find that reply--am I missing a thread? Dave reported it in reply to Linus' 4.10-rc7 announcement. Looks like neither you nor linux-nfs were Cc'ed on that. > OK, so for 4.10 I have: > > nfsd: don't get write access twice in nfsd_setattr > nfsd: restore owner override for truncate Yepp. Sorry for the mess.