Return-Path: Received: from mail-vk0-f49.google.com ([209.85.213.49]:36626 "EHLO mail-vk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbdBMPe7 (ORCPT ); Mon, 13 Feb 2017 10:34:59 -0500 Received: by mail-vk0-f49.google.com with SMTP id t8so62670141vke.3 for ; Mon, 13 Feb 2017 07:34:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1476190256-1677-1-git-send-email-agruenba@redhat.com> <1476190256-1677-3-git-send-email-agruenba@redhat.com> From: Andreas Gruenbacher Date: Mon, 13 Feb 2017 16:34:53 +0100 Message-ID: Subject: Re: [PATCH v27 02/21] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags To: Miklos Szeredi Cc: Alexander Viro , Christoph Hellwig , "Theodore Ts'o" , Andreas Dilger , "J. Bruce Fields" , Jeff Layton , Trond Myklebust , Anna Schumaker , Dave Chinner , linux-ext4 , XFS Developers , LKML , linux-fsdevel , Linux NFS Mailing List , linux-cifs@vger.kernel.org, Linux API Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: Miklos, On Fri, Dec 2, 2016 at 10:22 AM, Miklos Szeredi wrote: > On Tue, Oct 11, 2016 at 2:50 PM, Andreas Gruenbacher > wrote: >> Richacls distinguish between creating non-directories and directories. To >> support that, add an isdir parameter to may_create(). When checking >> inode_permission() for create permission, pass in an additional >> MAY_CREATE_FILE or MAY_CREATE_DIR mask flag. >> >> Add may_replace() to allow checking for delete and create access when >> replacing an existing file in vfs_rename(). > > That works for plain rename, but not for RENAME_EXCHANGE: is_dir and > new_is_dir may be different, which means we can be deleting a > non-directory *and* creating a directory in one dir and vice versa in > the other. ok, I see now. Should be fixed in the latest posting from just now. Thanks a lot, Andreas