Return-Path: Received: from mga07.intel.com ([134.134.136.100]:30353 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755932AbdBQT1x (ORCPT ); Fri, 17 Feb 2017 14:27:53 -0500 Date: Sat, 18 Feb 2017 03:35:21 +0800 From: kbuild test robot To: "J. Bruce Fields" Cc: kbuild-all@01.org, Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, Andreas Gruenbacher , Weston Andros Adamson , "J. Bruce Fields" Subject: [PATCH] nfsd4: fix ifnullfree.cocci warnings Message-ID: <20170217193521.GA62045@lkp-sb04.lkp.intel.com> References: <201702180301.FBMzLirK%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1487349854-9732-4-git-send-email-bfields@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: fs/nfs/nfs4proc.c:5135:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: J. Bruce Fields Signed-off-by: Fengguang Wu --- nfs4proc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -5131,8 +5131,7 @@ static ssize_t __nfs4_get_acl_uncached(s if (buf && ret > buflen) ret = -ERANGE; out: - if (priv_buf) - kfree(priv_buf); + kfree(priv_buf); return ret; }