Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:47770 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639AbdCHSpw (ORCPT ); Wed, 8 Mar 2017 13:45:52 -0500 Date: Wed, 8 Mar 2017 09:25:49 -0800 From: Christoph Hellwig To: "J. Bruce Fields" Cc: Christoph Hellwig , Olga Kornievskaia , Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org Subject: Re: [RFC v1 01/19] fs: Don't copy beyond the end of the file Message-ID: <20170308172549.GA32011@infradead.org> References: <20170302160123.30375-1-kolga@netapp.com> <20170302160123.30375-2-kolga@netapp.com> <20170302162221.GA6854@infradead.org> <20170303204747.GE13877@fieldses.org> <20170307234051.GA29977@infradead.org> <20170308170521.GA1020@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170308170521.GA1020@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Mar 08, 2017 at 12:05:21PM -0500, J. Bruce Fields wrote: > Since copy isn't atomic that check is never going to be reliable. That's true for everything that COPY does. By that logic we should not implement it at all (a logic that I'd fully support)