Return-Path: Received: from fieldses.org ([173.255.197.46]:59026 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992AbdCIU0P (ORCPT ); Thu, 9 Mar 2017 15:26:15 -0500 Date: Thu, 9 Mar 2017 15:26:10 -0500 From: "J. Bruce Fields" To: Jeff Layton Cc: Kinglong Mee , Trond Myklebust , "linux-nfs@vger.kernel.org" , Anna Schumaker Subject: Re: [PATCH] SUNRPC/backchanel: set XPT_CONG_CTRL flag for bc xprt Message-ID: <20170309202610.GF3929@fieldses.org> References: <1488885081.2788.0.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1488885081.2788.0.camel@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: Thanks! Applying.--b. On Tue, Mar 07, 2017 at 06:11:21AM -0500, Jeff Layton wrote: > On Tue, 2017-03-07 at 17:22 +0800, Kinglong Mee wrote: > > The xprt for backchannel is created separately, not in TCP/UDP code. > > Because without the flags, the requests from NFSv41 backchannel are > > rejected in svc_process_common(), > > > > 1191 if (versp->vs_need_cong_ctrl && > > 1192 !test_bit(XPT_CONG_CTRL, &rqstp->rq_xprt->xpt_flags)) > > 1193 goto err_bad_vers; > > > > Fixes: 5283b03ee5 ("nfs/nfsd/sunrpc: enforce transport...") > > Signed-off-by: Kinglong Mee > > --- > > net/sunrpc/svcsock.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c > > index 8931e33..2b720fa 100644 > > --- a/net/sunrpc/svcsock.c > > +++ b/net/sunrpc/svcsock.c > > @@ -1635,6 +1635,7 @@ static struct svc_xprt *svc_bc_create_socket(struct svc_serv *serv, > > > > xprt = &svsk->sk_xprt; > > svc_xprt_init(net, &svc_tcp_bc_class, xprt, serv); > > + set_bit(XPT_CONG_CTRL, &svsk->sk_xprt.xpt_flags); > > > > serv->sv_bc_xprt = xprt; > > > > Good catch. > > Reviewed-by: Jeff Layton