Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:43186 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdCOTJw (ORCPT ); Wed, 15 Mar 2017 15:09:52 -0400 From: Trond Myklebust To: "linux-nfs@vger.kernel.org" , "andros@netapp.com" Subject: Re: [PATCH Version 1 1/1] NFS free the layoutget slot before calling pnfs_layout_process Date: Wed, 15 Mar 2017 19:09:46 +0000 Message-ID: <1489604984.10364.1.camel@primarydata.com> References: <20170315151851.5762-1-andros@netapp.com> In-Reply-To: <20170315151851.5762-1-andros@netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gV2VkLCAyMDE3LTAzLTE1IGF0IDExOjE4IC0wNDAwLCBhbmRyb3NAbmV0YXBwLmNvbSB3cm90 ZToNCj4gRnJvbTogQW5keSBBZGFtc29uIDxhbmRyb3NAbmV0YXBwLmNvbT4NCj4gDQo+IE90aGVy d2lzZSBubyBzbG90cyBjb3VsZCBiZSBhdmFpbGFibGUgZm9yIHRoZSBwb3RlbnRpYWwNCj4gcG5m c19sYXlvdXRfcHJvY2VzcyBnZXRkZXZpY2VpbmZvIGNhbGwgYW5kIHRoZSBjbGllbnQgaGFuZ3Mg b24gcE5GUw0KPiBJL08uDQo+IA0KPiBUaGlzIG9jY3VycyBpbiB0ZXN0aW5nIGFnYWluc3QgdGhl IHB5bmZzIHBORlMgc2VydmVyIHdoZXJlIHRoZQ0KPiB0aGUgb24td2lyZSByZXBseSBoaWdoZXN0 X3Nsb3RpZCBhbmQgc2xvdCBpZCBhcmUgemVybywgYW5kIHRoZQ0KPiB0YXJnZXQgaGlnaCBzbG90 IGlkIGlzIDggKG5lZ290aWF0ZWQgaW4gQ1JFQVRFX1NFU1NJT04pLg0KPiANCj4gVGhlIGludGVy bmFsIGZvcmUgY2hhbm5lbCBzbG90IHRhYmxlIG1heF9zbG90aWQsIHRoZSBtYXhpbXVtIGFsbG93 ZWQNCj4gdGFibGUgc2xvdGlkIHZhbHVlLCBoYXMgYmVlbiByZWR1Y2VkIHZpYSBuZnM0MV9zZXRf bWF4X3Nsb3RpZF9sb2NrZWQNCj4gwqBmcm9tIDggdG8gMS7CoMKgVGh1cyB0aGVyZSBpcyBvbmUg c2xvdCAoc2xvdGlkIDApIGF2YWlsYWJsZSBmb3IgdXNlDQo+IGJ1dA0KPiBpdCBoYXMgbm90IGJl ZW4gZnJlZWQgYnkgbGF5b3V0Z2V0IHByb2lyIHRvIHRoZSBnZXRkZXZpY2VpbmZvDQo+IHJlcXVl c3QuDQo+IA0KPiBTbyB0aGUgbGF5b3V0IGdldCBjYWxsIGlzIHdhaXRpbmcgZm9yIHRoZSBnZXRk ZXZpY2VpbmZvIGNhbGwgdG8NCj4gY29tcGxldGUsDQo+IGFuZCB0aGUgZ2V0ZGV2aWNlaW5mbyBj YWxsIGlzIHdhaXRpbmcgZm9yIGxheW91dGdldCB0byBmcmVlIHRoZSBzbG90Lg0KPiANCj4gU2ln bmVkLW9mZi1ieTogQW5keSBBZGFtc29uIDxhbmRyb3NAbmV0YXBwLmNvbT4NCj4gLS0tDQo+IMKg ZnMvbmZzL25mczRwcm9jLmMgfCAyICstDQo+IMKgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZnMvbmZzL25mczRwcm9jLmMg Yi9mcy9uZnMvbmZzNHByb2MuYw0KPiBpbmRleCAxYjE4MzY4Li44Y2E5MmQwIDEwMDY0NA0KPiAt LS0gYS9mcy9uZnMvbmZzNHByb2MuYw0KPiArKysgYi9mcy9uZnMvbmZzNHByb2MuYw0KPiBAQCAt ODUwNCwxMCArODUwNCwxMCBAQCBuZnM0X3Byb2NfbGF5b3V0Z2V0KHN0cnVjdCBuZnM0X2xheW91 dGdldA0KPiAqbGdwLCBsb25nICp0aW1lb3V0LCBnZnBfdCBnZnBfZmxhZ3MpDQo+IMKgCQkJJmxn cC0+cmVzLnN0YXRlaWQsDQo+IMKgCQkJc3RhdHVzKTsNCj4gwqANCj4gKwluZnM0X3NlcXVlbmNl X2ZyZWVfc2xvdCgmbGdwLT5yZXMuc2VxX3Jlcyk7DQo+IMKgCS8qIGlmIGxheW91dHAtPmxlbiBp cyAwLCBuZnM0X2xheW91dGdldF9wcmVwYXJlIGNhbGxlZA0KPiBycGNfZXhpdCAqLw0KPiDCoAlp ZiAoc3RhdHVzID09IDAgJiYgbGdwLT5yZXMubGF5b3V0cC0+bGVuKQ0KPiDCoAkJbHNlZyA9IHBu ZnNfbGF5b3V0X3Byb2Nlc3MobGdwKTsNCj4gLQluZnM0X3NlcXVlbmNlX2ZyZWVfc2xvdCgmbGdw LT5yZXMuc2VxX3Jlcyk7DQo+IMKgCXJwY19wdXRfdGFzayh0YXNrKTsNCj4gwqAJZHByaW50aygi PC0tICVzIHN0YXR1cz0lZFxuIiwgX19mdW5jX18sIHN0YXR1cyk7DQo+IMKgCWlmIChzdGF0dXMp DQoNClRoZSBwbGFjZW1lbnQgb2YgdGhlIGNhbGwgdG8gbmZzNF9zZXF1ZW5jZV9mcmVlX3Nsb3Qo KSBhZnRlciB0aGUgY2FsbA0KdG8gcG5mc19sYXlvdXRfcHJvY2VzcygpIGlzIGRlbGliZXJhdGUs IGFuZCBpcyBuZWVkZWQgaW4gb3JkZXIgdG8NCmVuc3VyZSB0aGF0IGxheW91dHJlY2FsbCBjYWxs YmFja3MgYXJlIHByb2Nlc3NlZCBjb3JyZWN0bHkgaW4gb3JkZXINCmFmdGVyIHRoZSBsYXlvdXRn ZXQgaGFzIGJlZW4gcHJvY2Vzc2VkIChzZWUgcmVmZXJyaW5nX2NhbGxfZXhpc3RzKCkpLg0KDQpU aGUgY2FsbCB0byBuZnM0X2ZpbmRfZ2V0X2RldmljZWlkKCkgbmVlZHMgdG8gYmUgbW92ZWQgb3V0 IG9mDQpwbmZzX3VwZGF0ZV9sYXlvdXQoKS4NCkluIHRoZSBmbGV4ZmlsZXMgZHJpdmVyLCBpdCB3 YXMgbW92ZWQgdG8gbmZzNF9mZl9sYXlvdXRfcHJlcGFyZV9kcygpLA0KYnV0IGl0IGxvb2tzIHRv IG1lIGFzIGlmIHRoZSBmaWxlcyBkcml2ZXIgbmVlZHMgdG8gY2FsbCBpdCBlYXJsaWVyIGR1ZQ0K dG8gdGhlIG5lZWQgdG8gY2FsY3VsYXRlIHN0cmlwZXMuIFBlcmhhcHMgdGhlIHJpZ2h0IHRoaW5n IGlzIHRvIGFkZCBhDQp3cmFwcGVyIGFyb3VuZCBwbmZzX3VwZGF0ZV9sYXlvdXQoKSBpbiBmcy9u ZnMvZmlsZWxheW91dC9maWxlbGF5b3V0LmMNCnRoYXQgY2FuIGJlIGNhbGxlZCBieSBib3RoIGZp bGVsYXlvdXRfcGdfaW5pdF9yZWFkKCkgYW5kDQpmaWxlbGF5b3V0X3BnX2luaXRfd3JpdGUoKT8N Cg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lciwgUHJp bWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg==