Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:45973 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbdDMUu6 (ORCPT ); Thu, 13 Apr 2017 16:50:58 -0400 From: Trond Myklebust To: "Anna.Schumaker@Netapp.com" , "aglo@umich.edu" CC: "linux-nfs@vger.kernel.org" , "bjschuma@netapp.com" Subject: Re: RFC: fixing kernel oops on interrupted COMMIT from nfs_commit_file Date: Thu, 13 Apr 2017 20:50:50 +0000 Message-ID: <1492116646.11542.1.camel@primarydata.com> References: <1492109480.7917.1.camel@primarydata.com> <9eb6ccc9-501a-5635-05f9-7bd2fd4f4563@Netapp.com> In-Reply-To: <9eb6ccc9-501a-5635-05f9-7bd2fd4f4563@Netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gVGh1LCAyMDE3LTA0LTEzIGF0IDE2OjEzIC0wNDAwLCBBbm5hIFNjaHVtYWtlciB3cm90ZToN Cj4gDQo+IE9uIDA0LzEzLzIwMTcgMDM6MTYgUE0sIEFubmEgU2NodW1ha2VyIHdyb3RlOg0KPiA+ IA0KPiA+IA0KPiA+IE9uIDA0LzEzLzIwMTcgMDM6MDcgUE0sIE9sZ2EgS29ybmlldnNrYWlhIHdy b3RlOg0KPiA+ID4gT24gVGh1LCBBcHIgMTMsIDIwMTcgYXQgMjo1MSBQTSwgVHJvbmQgTXlrbGVi dXN0DQo+ID4gPiA8dHJvbmRteUBwcmltYXJ5ZGF0YS5jb20+IHdyb3RlOg0KPiA+ID4gPiBPbiBU aHUsIDIwMTctMDQtMTMgYXQgMTQ6MDAgLTA0MDAsIE9sZ2EgS29ybmlldnNrYWlhIHdyb3RlOg0K PiA+ID4gPiA+IEhpIGZvbGtzLA0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IExvb2tpbmcgZm9yIHN1 Z2dlc3Rpb25zIG9uIGhvdyB0byBmaXggYSBrZXJuZWwgb29wcy4NCj4gPiA+ID4gPiANCj4gPiA+ ID4gPiBJdCdzIHBvc3NpYmxlIHRoYXQgdGhlcmUgaXMgYSBjdHJsLWMgd2hlbiB0aGUgQ09NTUlU IGlzIHNlbmQuDQo+ID4gPiA+ID4gSW4gY2FzZQ0KPiA+ID4gPiA+IG9mIHRoZSBDT1BZLCBpdCBj YWxscw0KPiA+ID4gPiA+IG5mc19jb21taXRfZmlsZSgpIHdoaWNoIGNhbGxzIHdhaXRfb25fY29t bWl0KCkgdGhhdCBpcw0KPiA+ID4gPiA+IGludGVycnVwdGVkIGJ5DQo+ID4gPiA+ID4gdGhlIGNy dGwtYyBhbmQgZnJlZXMgdGhlIG5mc19wYWdlIHJlcXVlc3QuIFNvIHdoZW4NCj4gPiA+ID4gPiBh c3luY2hyb25vdXMNCj4gPiA+ID4gPiBDT01NSVQNCj4gPiA+ID4gPiBycGMgY29tZXMgYmFjayBp dCB0cmllZCB0byB1c2UgdGhlIG5mc19wYWdlIHJlcXVlc3QgYW5kIGdldHMNCj4gPiA+ID4gPiB0 aGUNCj4gPiA+ID4gPiBvb3BzLg0KPiA+ID4gPiA+IA0KPiA+ID4gPiANCj4gPiA+ID4gSXMgdGhh dCBjYWxsIHRvIG5mc19mcmVlX3JlcXVlc3QoKSBpbiBuZnNfY29tbWl0X2ZpbGUoKQ0KPiA+ID4g PiBjb3JyZWN0Pw0KPiA+ID4gDQo+ID4gPiB5ZXMsIG5mc19jb21taXRfZmlsZSgpIGNyZWF0ZXMg YSBuZXcgcmVxdWVzdCB2aWENCj4gPiA+IG5mc19jcmVhdGVfcmVxdWVzdCgpDQo+ID4gPiBhbmQg aW4gdGhlIGVuZCBpZiBjYWxscyBuZnNfZnJlZV9yZXF1ZXN0KCk7DQo+ID4gPiANCj4gPiA+ID4g SXQgbG9va3MgdG8gbWUgYXMgaWYgdGhlIHNhbWUgcmVxdWVzdCB3aWxsIGJlIGZyZWVkIGluDQo+ ID4gPiA+IG5mc19jb21taXRfcmVsZWFzZV9wYWdlcygpLg0KPiA+ID4gDQo+ID4gPiBzbyBuZnNf Y29tbWl0X3JlbGVhc2VfcGFnZXMoKSB0aHJ1IHRoZQ0KPiA+ID4gbmZzX3VubG9ja19hbmRfcmVs ZWFzZV9yZXF1ZXN0KCkgaXMgZ29pbmcgdG8gY2FsbA0KPiA+ID4gbmZzX3JlbGVhc2VfcmVxdWVz dCgpIGZyb20gcmVxLT53Yl9rcmVmLi4gSSdtIG5vdCBzdXJlIGlmIHRoaXMgaXMNCj4gPiA+IHNl dHVwKD8pIGZvciB0aGUgY29weSBjb21taXQgcGF0aD8NCj4gPiA+IA0KPiA+ID4gT3RoZXJ3aXNl LCBpdCB3b3VsZCBoYXZlIHNlZW0gdGhhdCB3ZSdkIGJlIGRvaW5nIGEgZG91YmxlIGZyZWUNCj4g PiA+IGFuZCBJDQo+ID4gPiBoYXZlbid0IHNlZW4gdGhhdCBpbiB0ZXN0aW5nIChub3QgdGhhdCBp dCBjYW4ndCBiZSB0cnVlKS4uLg0KPiA+IA0KPiA+IEkgaGF2ZW4ndCBzZWVuIGFueSBkb3VibGUt ZnJlZSBtZXNzYWdlcyBkdXJpbmcgbXkgdGVzdGluZyBlaXRoZXIsDQo+ID4gc28gSSB0aG91Z2h0 IGl0IHdhcyBva2F5LsKgwqBJdCdzIHBvc3NpYmxlIEknbSB3cm9uZywgdGhvdWdoLsKgwqBJDQo+ ID4gd29uZGVyIGlmIHRoaXMgaXMgc29tZXRoaW5nIHRoYXQgbWVtb3J5IHBvaXNvbmluZyBjYW4g aGVscCBmaWd1cmUNCj4gPiBvdXQ/DQo+IA0KPiBBZnRlciBzb21lIGV4cGVyaW1lbnRpbmcsIEkg Y2FuIHN0aWxsIHVzZSB0aGUgbmZzX3BhZ2UgYWZ0ZXINCj4gbmZzX2NvbW1pdF9pbm9kZSgpIGhh cyByZXR1cm5lZCB3aXRob3R1IGFueSBtZW1vcnkgaXNzdWVzLg0KPiANCg0KV2FpdC4uLg0KDQpP Sywgc28gbmZzX3NjYW5fY29tbWl0X2xpc3QoKSBkb2VzIGluZGVlZCB0YWtlIGEgcmVmZXJlbmNl IHRvIHRoZSByZXEtDQo+d2Jfa3JlZiwgc28gdGhhdCBiYWxhbmNlcyB0aGUgY2FsbCB0byBuZnNf cmVsZWFzZV9yZXF1ZXN0KCkgaW4NCm5mc19jb21taXRfcmVsZWFzZV9wYWdlcygpLCBob3dldmVy IGl0IGFsc28gbWVhbnMgdGhhdCB5b3Ugc2hvdWxkIG5vdA0KYmUgY2FsbGluZyBuZnNfZnJlZV9y ZXF1ZXN0KCksIHNpbmNlIGRvaW5nIHNvIGNpcmN1bXZlbnRzIHRoZQ0KcmVmY291bnRpbmcgbWVj aGFuaXNtLg0KDQpTZWNvbmRseSwgaWYgeW91IHdhbnQgdG8gcmVsZWFzZSB0aGUgcmVxdWVzdCBh bmQgeW91IGFyZSBub3Qgc3VyZQ0Kd2hldGhlciBvciBub3QgaXQgZ290IGNsZWFyZWQgb2ZmIHRo ZSBpbm9kZSdzIGNpbmZvIGNvbW1pdCBsaXN0IHlldCwNCnlvdSBtYXkgYWxzbyBuZWVkIHRvIGxv Y2sgdGhhdCByZXF1ZXN0IGFuZCBjYWxsDQpuZnNfY2xlYXJfcmVxdWVzdF9jb21taXQoKS4NCg0K LS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lciwgUHJpbWFy eURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg==