Return-Path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:36555 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbdECM4N (ORCPT ); Wed, 3 May 2017 08:56:13 -0400 MIME-Version: 1.0 In-Reply-To: <20170502221649.GA5970@birch.djwong.org> References: <20170317195233.4042-1-Anna.Schumaker@Netapp.com> <20170317220246.GA12585@birch.djwong.org> <20170320052457.GH14226@eguan.usersys.redhat.com> <20170502221649.GA5970@birch.djwong.org> From: Olga Kornievskaia Date: Wed, 3 May 2017 08:56:11 -0400 Message-ID: Subject: Re: [PATCH v5 0/5] Add copy_file_range() tests To: "Darrick J. Wong" Cc: Anna Schumaker , Eryu Guan , fstests@vger.kernel.org, linux-nfs , Christoph Hellwig Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, May 2, 2017 at 6:16 PM, Darrick J. Wong wrote: > On Mon, Mar 20, 2017 at 01:24:57PM +0800, Eryu Guan wrote: >> On Fri, Mar 17, 2017 at 03:02:46PM -0700, Darrick J. Wong wrote: >> > On Fri, Mar 17, 2017 at 03:52:28PM -0400, Anna Schumaker wrote: >> > > These tests exercise the copy_file_range() system call, and check copying >> > > data to both a new file and overwriting data inside an existing file. >> > > >> > > Sorry it took so long to get this version out. I forgot about these patches >> > > after the last submission. >> > >> > Hooray, tests finally! >> > >> > I had to bump the numbers up due to conflicts (it's usually best to pick >> > a really high number and let Eryu mvtest them to their real numbers), >> > but these mostly look ok. >> >> Usually the test numbers are not a problem, as long as the patchset is >> based on latest master and there's no test number conflicts :) >> >> Overall the tests look fine to me too. >> >> > >> > However, I do see that something isn't triggering an EINVAL return code: >> >> Same results here, tested with xfs/ext4/btrfs on 4.11-rc2 kernel. >> >> And another nitpick is the year in copyright, s/2016/2017/ ? > > Another month, another kernel release... can we please get these tests > fixed and integrated? > I'm curious when you say "testing with btrfs" does it mean NFS server exporting btrfs or does it mean just local btrfs? > --D > >> >> Thanks, >> Eryu >> -- >> To unsubscribe from this list: send the line "unsubscribe fstests" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html