Return-Path: Received: from fieldses.org ([173.255.197.46]:49258 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbdEDRgi (ORCPT ); Thu, 4 May 2017 13:36:38 -0400 Date: Thu, 4 May 2017 13:36:38 -0400 To: Chuck Lever Cc: Trond Myklebust , Linux NFS Mailing List Subject: Re: [RFC PATCH 2/5] NFS: Add a mount option to specify number of TCP connections to use Message-ID: <20170504173638.GA7023@fieldses.org> References: <20170428172535.7945-1-trond.myklebust@primarydata.com> <20170428172535.7945-2-trond.myklebust@primarydata.com> <20170428172535.7945-3-trond.myklebust@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: From: bfields@fieldses.org (J. Bruce Fields) Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, May 04, 2017 at 12:01:29PM -0400, Chuck Lever wrote: > > > On May 4, 2017, at 9:45 AM, Chuck Lever wrote: > > > > - Testing with a Linux server shows that the basic NFS/RDMA pieces > > work, but any OPEN operation gets NFS4ERR_GRACE, forever, when I use > > nconnect > 1. I'm looking into it. > > Reproduced with NFSv4.1, TCP, and nconnect=2. > > 363 /* > 364 * RFC5661 18.51.3 > 365 * Before RECLAIM_COMPLETE done, server should deny new lock > 366 */ > 367 if (nfsd4_has_session(cstate) && > 368 !test_bit(NFSD4_CLIENT_RECLAIM_COMPLETE, > 369 &cstate->session->se_client->cl_flags) && > 370 open->op_claim_type != NFS4_OPEN_CLAIM_PREVIOUS) > 371 return nfserr_grace; > > Server-side instrumentation confirms: > > May 4 11:28:29 klimt kernel: nfsd4_open: has_session returns true > May 4 11:28:29 klimt kernel: nfsd4_open: RECLAIM_COMPLETE is false > May 4 11:28:29 klimt kernel: nfsd4_open: claim_type is 0 > > Network capture shows the RPCs are interleaved between the two > connections as the client establishes its lease, and that appears > to be confusing the server. > > C1: NULL -> NFS4_OK > C1: EXCHANGE_ID -> NFS4_OK > C2: CREATE_SESSION -> NFS4_OK > C1: RECLAIM_COMPLETE -> NFS4ERR_CONN_NOT_BOUND_TO_SESSION What security flavors are involved? I believe the correct behavior depends on whether gss is in use or not. --b. > C1: PUTROOTFH | GETATTR -> NFS4ERR_SEQ_MISORDERED > C2: SEQUENCE -> NFS4_OK > C1: PUTROOTFH | GETATTR -> NFS4ERR_CONN_NOT_BOUND_TO_SESSION > C1: BIND_CONN_TO_SESSION -> NFS4_OK > C2: BIND_CONN_TO_SESSION -> NFS4_OK > C2: PUTROOTFH | GETATTR -> NFS4ERR_SEQ_MISORDERED > > .... mix of GETATTRs and other simple requests .... > > C1: OPEN -> NFS4ERR_GRACE > C2: OPEN -> NFS4ERR_GRACE > > The RECLAIM_COMPLETE operation failed, and the client does not > retry it. That leaves its lease stuck in GRACE. > > > -- > Chuck Lever > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html