Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:33564 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdFSPXN (ORCPT ); Mon, 19 Jun 2017 11:23:13 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v2 19/19] sunrpc: Disable splice for krb5i From: Chuck Lever In-Reply-To: <20170618073438.GA15358@infradead.org> Date: Mon, 19 Jun 2017 11:22:41 -0400 Cc: linux-rdma@vger.kernel.org, Linux NFS Mailing List Message-Id: <14AD4311-5092-441C-8A3B-F7EC7E801358@oracle.com> References: <20170616151535.14210.34926.stgit@klimt.1015granger.net> <20170616152254.14210.48071.stgit@klimt.1015granger.net> <20170617150705.GA27917@infradead.org> <20170618073438.GA15358@infradead.org> To: Christoph Hellwig Sender: linux-nfs-owner@vger.kernel.org List-ID: > On Jun 18, 2017, at 3:34 AM, Christoph Hellwig wrote: > > On Sat, Jun 17, 2017 at 01:23:24PM -0400, Chuck Lever wrote: >> >>> On Jun 17, 2017, at 11:07 AM, Christoph Hellwig wrote: >>> >>> On Fri, Jun 16, 2017 at 11:22:54AM -0400, Chuck Lever wrote: >>>> Running a multi-threaded 8KB fio test (70/30 mix), three or four out >>>> of twelve of the jobs fail when using krb5i. The failure is an EIO >>>> on a read. >>> >>> Just curious: what is the backing fs that you tested with? I'd be >>> curious if you see this on XFS for example. >> >> I was able to reproduce this with a tmpfs share and >> with an XFS share on NVMe LUNs. > > Interesting. XFS actually locks out all writes while doing a buffered > read, so we end up with two different read instance for the hash vs > the data, which does indeed sound dangerous. I'm going to submit this again with a comment change and Jeff's Reviewed-by. Can I add your Reviewed-by as well? -- Chuck Lever