Return-Path: Received: from mail-qk0-f195.google.com ([209.85.220.195]:34906 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbdGNVFS (ORCPT ); Fri, 14 Jul 2017 17:05:18 -0400 Message-ID: <1500066316.3755.7.camel@gmail.com> Subject: Re: [GIT PULL] Please pull NFS client changes for Linux 4.13 From: Daniel Micay To: Linus Torvalds Cc: Andrey Ryabinin , Kees Cook , Dave Jones , Anna Schumaker , Linux NFS Mailing List , linux-fsdevel , Linux Kernel Mailing List , "J. Bruce Fields" , Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com Date: Fri, 14 Jul 2017 17:05:16 -0400 In-Reply-To: <1500066114.3755.5.camel@gmail.com> References: <20170714142543.k5xcbnb4mww3sxpy@codemonkey.org.uk> <4c68e120-5ada-6ce1-30fd-e26155c9704e@virtuozzo.com> <1500064716.3755.1.camel@gmail.com> <1500066114.3755.5.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: > The reason q_size isn't used is because it doesn't yet prevent read > overflow. The commit message mentions that among the current > limitations > along with __builtin_object_size(ptr, 1). Er rather, in strlcat, the q_size is unused after the fast path is because strnlen obtains the constant again itself.