Return-Path: Received: from mx2.suse.de ([195.135.220.15]:39825 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750783AbdGZNaK (ORCPT ); Wed, 26 Jul 2017 09:30:10 -0400 Date: Wed, 26 Jul 2017 15:30:09 +0200 Message-ID: From: Takashi Iwai To: Anna Schumaker Cc: Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [REGRESSION 4.13-rc] NFS returns -EACCESS at the first read In-Reply-To: References: MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, 26 Jul 2017 14:57:07 +0200, Anna Schumaker wrote: > > Hi Takashi, > > On 07/26/2017 08:54 AM, Takashi Iwai wrote: > > Hi, > > > > I seem hitting a regression of NFS client on the today's Linus git > > tree. The symptom is that the file read over NFS returns occasionally > > -EACCESS at the first read. When I try to read the same file again > > (or do some other thing), I can read it successfully. > > > > The git bisection leaded to the commit > > bd8b2441742b49c76bec707757bd9c028ea9838e > > NFS: Store the raw NFS access mask in the inode's access cache > > > > > > Any further hint for debugging? > > Does the patch in this email thread help? http://www.spinics.net/lists/linux-nfs/msg64930.html Thanks, I gave it a shot and the result looks good. Feel free to my tested-by tag: Tested-by: Takashi Iwai Though, when I look around the code, I feel somehow uneasy by that still MAY_XXX is used for nfs_access_entry.mask, e.g. in nfs3_proc_access() or nfs4_proc_access(). Are these function OK without the similar conversion? thanks, Takashi