Return-Path: Received: from mx142.netapp.com ([216.240.21.19]:5183 "EHLO mx142.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbdHKTAl (ORCPT ); Fri, 11 Aug 2017 15:00:41 -0400 Subject: =?UTF-8?Q?Re:_[PATCH]_pnfs/blocklayout:_require_64-bit_=d1=95ector?= =?UTF-8?Q?=5ft?= To: Christoph Hellwig , Trond Myklebust , CC: Arnd Bergmann References: <20170805085914.3188-1-hch@lst.de> <20170811151411.GA4301@lst.de> From: Anna Schumaker Message-ID: <51b0ddfc-49bd-a48d-c1cd-db7c9bc0ed56@Netapp.com> Date: Fri, 11 Aug 2017 15:00:25 -0400 MIME-Version: 1.0 In-Reply-To: <20170811151411.GA4301@lst.de> Content-Type: text/plain; charset=utf-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Christoph, On 08/11/2017 11:14 AM, Christoph Hellwig wrote: > Trond, Anna, > > can you pick this up? Maybe even for 3.13 given that it should > be pretty harmless for 98% of the configfs, and will prevent problems > for the others. The patch looks okay to me, so I'll take it for the next rc. Anna > > On Sat, Aug 05, 2017 at 10:59:14AM +0200, Christoph Hellwig wrote: >> The blocklayout code does not compile cleanly for a 32-bit sector_t, >> and also has no reliable checks for devices sizes, which makes it >> unsafe to use with a kernel that doesn't support large block devices. >> >> Signed-off-by: Christoph Hellwig >> Reported-by: Arnd Bergmann >> Fixes: 5c83746a0cf2 ("pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsing") >> --- >> fs/nfs/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig >> index 69d02cf8cf37..5f93cfacb3d1 100644 >> --- a/fs/nfs/Kconfig >> +++ b/fs/nfs/Kconfig >> @@ -121,6 +121,7 @@ config PNFS_FILE_LAYOUT >> config PNFS_BLOCK >> tristate >> depends on NFS_V4_1 && BLK_DEV_DM >> + depends on 64BIT || LBDAF >> default NFS_V4 >> >> config PNFS_FLEXFILE_LAYOUT >> -- >> 2.11.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > ---end quoted text--- >