Return-Path: Received: from fieldses.org ([173.255.197.46]:45276 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbdIMOmG (ORCPT ); Wed, 13 Sep 2017 10:42:06 -0400 Date: Wed, 13 Sep 2017 10:42:06 -0400 From: "J. Bruce Fields" To: Olga Kornievskaia Cc: Olga Kornievskaia , Trond Myklebust , Anna Schumaker , "J. Bruce Fields" , linux-nfs Subject: Re: [RFC v3 25/42] NFSD add COPY_NOTIFY operation Message-ID: <20170913144206.GD12896@fieldses.org> References: <20170711164416.1982-1-kolga@netapp.com> <20170711164416.1982-26-kolga@netapp.com> <20170906213703.GE24694@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Sep 13, 2017 at 10:38:46AM -0400, Olga Kornievskaia wrote: > On Wed, Sep 6, 2017 at 5:37 PM, J. Bruce Fields wrote: > > On Tue, Jul 11, 2017 at 12:43:59PM -0400, Olga Kornievskaia wrote: > >> +struct nfsd4_copy_notify { > >> + /* request */ > >> + stateid_t cpn_src_stateid; > >> + struct nl4_server cpn_dst; > >> + > >> + /* response */ > >> + /* Note: cpn_src_stateid is used for cnr_stateid */ > > > > That might be worth a little more explanation. > > I'm opting for removing it from this patch? It's just valid for that > patch saying that for the > moment the same cpn_src_stateid is returned fort he cnr_stateid in the > later patch (29) > we will add the generation of the unique stateid used for the copy. Got it, yes, that did confuse me, dropping the comment and noting the coming change in the changelog would be great.--b. > > > > > --b. > > > >> + u64 cpn_sec; > >> + u32 cpn_nsec; > >> + struct nl4_servers cpn_src; > >> +}; > >> + > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html