Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:58994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbdJBQiy (ORCPT ); Mon, 2 Oct 2017 12:38:54 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5934325778 for ; Mon, 2 Oct 2017 16:38:54 +0000 (UTC) Date: Mon, 2 Oct 2017 12:38:52 -0400 From: "J. Bruce Fields" To: Steve Dickson Cc: Justin Mitchell , linux-nfs Subject: Re: [PATCH 0/7] nfs-utils: Merge libnfsidmap tree with nfs-utils UPDATED Message-ID: <20171002163852.GC16092@parsley.fieldses.org> References: <1505397745.3665.4.camel@redhat.com> <300b358d-689a-1e6b-c91d-c8e46c740ab1@RedHat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <300b358d-689a-1e6b-c91d-c8e46c740ab1@RedHat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Oct 02, 2017 at 10:03:06AM -0400, Steve Dickson wrote: > > > On 09/14/2017 10:02 AM, Justin Mitchell wrote: > > It was suggested that merging the trees is more desirable than splitting > > the common code out into a shared library, so this patch set attempts to > > merge the libnfsidmap code into nfs-utils. > > > > The main body of the code, copyright notices, and readme are copied > > across, omitting the shared conffile code, and trimming unused files > > like strlcpy.c and queue.h. The build files of both are adjusted to the > > new structure, and the dependent nfs-utils now link to the included > > shared library instead of an external one. > > > > The source libnfsidmap tree did include some packaging files for > > debian/dkpg which have been omitted, there are no packaging materials in > > nfs-utils to merge them with, and i welcome advice on what should be > > done here. > > > > Change: libnfsidmap imported as support/nfsidmap/ > A quick status on this... I'm working on this but this patch is going > to cause a packaging nightmare... since the libnfsidmap package is > required by nfs-utils which now is installing that lib... so > this might take some time... Would it help to start by keeping the separate libnfsidmap rpm, but just building it from nfs-utils instead of from separate source? --b.