Return-Path: Received: from fieldses.org ([173.255.197.46]:60350 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbdJ3Otn (ORCPT ); Mon, 30 Oct 2017 10:49:43 -0400 Date: Mon, 30 Oct 2017 10:49:43 -0400 From: "J. Bruce Fields" To: Vasily Averin Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton Subject: Re: [PATCH] nlm_shutdown_hosts_net() cleanup Message-ID: <20171030144943.GG14098@fieldses.org> References: <1d1a25d8-a34b-5175-bb6a-9549041c11f4@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1d1a25d8-a34b-5175-bb6a-9549041c11f4@virtuozzo.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote: > nlm_complain_hosts() walk through nlm_server_hosts hlist that should be > protected by nlm_host_mutex. I haven't looked at the NLM locking in ages. Do we know who else might actually be accessing this list concurrently? --b. > > Signed-off-by: Vasily Averin > --- > fs/lockd/host.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/lockd/host.c b/fs/lockd/host.c > index d716c99..089c1d7 100644 > --- a/fs/lockd/host.c > +++ b/fs/lockd/host.c > @@ -617,9 +617,8 @@ nlm_shutdown_hosts_net(struct net *net) > > /* Then, perform a garbage collection pass */ > nlm_gc_hosts(net); > - mutex_unlock(&nlm_host_mutex); > - > nlm_complain_hosts(net); > + mutex_unlock(&nlm_host_mutex); > } > > /* > -- > 2.7.4