Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:42071 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932624AbdKCSg6 (ORCPT ); Fri, 3 Nov 2017 14:36:58 -0400 From: Trond Myklebust To: "bfields@fieldses.org" , "aweits@rit.edu" , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH v3] nfsd: deal with revoked delegations appropriately Date: Fri, 3 Nov 2017 18:36:55 +0000 Message-ID: <1509734212.21477.16.camel@primarydata.com> References: <20171103180631.76071-1-aweits@rit.edu> In-Reply-To: <20171103180631.76071-1-aweits@rit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: VGhhbmtzIGZvciB0aGUgcXVpY2sgdHVybmFyb3VuZCENCg0KT24gRnJpLCAyMDE3LTExLTAzIGF0 IDE0OjA2IC0wNDAwLCBBbmRyZXcgRWxibGUgd3JvdGU6DQo+IElmIGEgZGVsZWdhdGlvbiBoYXMg YmVlbiByZXZva2VkIGJ5IHRoZSBzZXJ2ZXIsIG9wZXJhdGlvbnMgdXNpbmcgdGhhdA0KPiBkZWxl Z2F0aW9uIHNob3VsZCBlcnJvciBvdXQgd2l0aCBORlM0RVJSX0RFTEVHX1JFVk9LRUQgaW4gdGhl ID40LjENCj4gY2FzZSwgYW5kIE5GUzRFUlJfQkFEX1NUQVRFSUQgb3RoZXJ3aXNlLg0KPiANCj4g U2lnbmVkLW9mZi1ieTogQW5kcmV3IEVsYmxlIDxhd2VpdHNAcml0LmVkdT4NCg0KUmV2aWV3ZWQt Ynk6IFRyb25kIE15a2xlYnVzdCA8dHJvbmQubXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbT4NCg0K PiAtLS0NCj4gIHYyOiBkZWNvbmZsaWN0aW5nIHdpdGggVHJvbmQncyBPUEVOL0NMT1NFIGxvY2tp bmcgd29yaw0KPiAgdjM6IGRvbid0IHJldHVybiBORlM0X09LIG9uIERFTEVHUkVUVVJOIHdpdGgg cmV2b2tlZCBkZWxlZ2F0aW9uDQo+ICANCj4gIGZzL25mc2QvbmZzNHN0YXRlLmMgfCAyNSArKysr KysrKysrKysrKysrKysrKysrKystDQo+ICAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2ZzL25mc2QvbmZzNHN0YXRlLmMg Yi9mcy9uZnNkL25mczRzdGF0ZS5jDQo+IGluZGV4IDBjMDRmODFhYTYzYi4uZDM4NmQ1NjllZGJj IDEwMDY0NA0KPiAtLS0gYS9mcy9uZnNkL25mczRzdGF0ZS5jDQo+ICsrKyBiL2ZzL25mc2QvbmZz NHN0YXRlLmMNCj4gQEAgLTM5NjYsNyArMzk2Niw4IEBAIHN0YXRpYyBzdHJ1Y3QgbmZzNF9kZWxl Z2F0aW9uDQo+ICpmaW5kX2RlbGVnX3N0YXRlaWQoc3RydWN0IG5mczRfY2xpZW50ICpjbCwgc3Rh dGVpDQo+ICB7DQo+ICAJc3RydWN0IG5mczRfc3RpZCAqcmV0Ow0KPiAgDQo+IC0JcmV0ID0gZmlu ZF9zdGF0ZWlkX2J5X3R5cGUoY2wsIHMsIE5GUzRfREVMRUdfU1RJRCk7DQo+ICsJcmV0ID0gZmlu ZF9zdGF0ZWlkX2J5X3R5cGUoY2wsIHMsDQo+ICsJCQkJTkZTNF9ERUxFR19TVElEfE5GUzRfUkVW T0tFRF9ERUxFR19TDQo+IFRJRCk7DQo+ICAJaWYgKCFyZXQpDQo+ICAJCXJldHVybiBOVUxMOw0K PiAgCXJldHVybiBkZWxlZ3N0YXRlaWQocmV0KTsNCj4gQEAgLTM5ODksNiArMzk5MCwxMiBAQCBz dGF0aWMgYm9vbCBuZnNkNF9pc19kZWxlZ19jdXIoc3RydWN0DQo+IG5mc2Q0X29wZW4gKm9wZW4p DQo+ICAJZGVsZWcgPSBmaW5kX2RlbGVnX3N0YXRlaWQoY2wsICZvcGVuLT5vcF9kZWxlZ2F0ZV9z dGF0ZWlkKTsNCj4gIAlpZiAoZGVsZWcgPT0gTlVMTCkNCj4gIAkJZ290byBvdXQ7DQo+ICsJaWYg KGRlbGVnLT5kbF9zdGlkLnNjX3R5cGUgPT0gTkZTNF9SRVZPS0VEX0RFTEVHX1NUSUQpIHsNCj4g KwkJbmZzNF9wdXRfc3RpZCgmZGVsZWctPmRsX3N0aWQpOw0KPiArCQlpZiAoY2wtPmNsX21pbm9y dmVyc2lvbikNCj4gKwkJCXN0YXR1cyA9IG5mc2Vycl9kZWxlZ19yZXZva2VkOw0KPiArCQlnb3Rv IG91dDsNCj4gKwl9DQo+ICAJZmxhZ3MgPSBzaGFyZV9hY2Nlc3NfdG9fZmxhZ3Mob3Blbi0+b3Bf c2hhcmVfYWNjZXNzKTsNCj4gIAlzdGF0dXMgPSBuZnM0X2NoZWNrX2RlbGVnbW9kZShkZWxlZywg ZmxhZ3MpOw0KPiAgCWlmIChzdGF0dXMpIHsNCj4gQEAgLTQ4NTgsNiArNDg2NSwxNiBAQCBzdGF0 aWMgX19iZTMyIG5mc2Q0X3ZhbGlkYXRlX3N0YXRlaWQoc3RydWN0DQo+IG5mczRfY2xpZW50ICpj bCwgc3RhdGVpZF90ICpzdGF0ZWlkKQ0KPiAgCQkgICAgIHN0cnVjdCBuZnM0X3N0aWQgKipzLCBz dHJ1Y3QgbmZzZF9uZXQgKm5uKQ0KPiAgew0KPiAgCV9fYmUzMiBzdGF0dXM7DQo+ICsJYm9vbCBy ZXR1cm5fcmV2b2tlZCA9IGZhbHNlOw0KPiArDQo+ICsJLyoNCj4gKwkgKiAgb25seSByZXR1cm4g cmV2b2tlZCBkZWxlZ2F0aW9ucyBpZiBleHBsaWNpdGx5IGFza2VkLg0KPiArCSAqICBvdGhlcndp c2Ugd2UgcmVwb3J0IHJldm9rZWQgb3IgYmFkX3N0YXRlaWQgc3RhdHVzLg0KPiArCSAqLw0KPiAr CWlmICh0eXBlbWFzayAmIE5GUzRfUkVWT0tFRF9ERUxFR19TVElEKQ0KPiArCQlyZXR1cm5fcmV2 b2tlZCA9IHRydWU7DQo+ICsJZWxzZSBpZiAodHlwZW1hc2sgJiBORlM0X0RFTEVHX1NUSUQpDQo+ ICsJCXR5cGVtYXNrIHw9IE5GUzRfUkVWT0tFRF9ERUxFR19TVElEOw0KPiAgDQo+ICAJaWYgKFpF Uk9fU1RBVEVJRChzdGF0ZWlkKSB8fCBPTkVfU1RBVEVJRChzdGF0ZWlkKSkNCj4gIAkJcmV0dXJu IG5mc2Vycl9iYWRfc3RhdGVpZDsNCj4gQEAgLTQ4NzIsNiArNDg4OSwxMiBAQCBzdGF0aWMgX19i ZTMyIG5mc2Q0X3ZhbGlkYXRlX3N0YXRlaWQoc3RydWN0DQo+IG5mczRfY2xpZW50ICpjbCwgc3Rh dGVpZF90ICpzdGF0ZWlkKQ0KPiAgCSpzID0gZmluZF9zdGF0ZWlkX2J5X3R5cGUoY3N0YXRlLT5j bHAsIHN0YXRlaWQsIHR5cGVtYXNrKTsNCj4gIAlpZiAoISpzKQ0KPiAgCQlyZXR1cm4gbmZzZXJy X2JhZF9zdGF0ZWlkOw0KPiArCWlmICgoKCpzKS0+c2NfdHlwZSA9PSBORlM0X1JFVk9LRURfREVM RUdfU1RJRCkgJiYNCj4gIXJldHVybl9yZXZva2VkKSB7DQo+ICsJCW5mczRfcHV0X3N0aWQoKnMp Ow0KPiArCQlpZiAoY3N0YXRlLT5taW5vcnZlcnNpb24pDQo+ICsJCQlyZXR1cm4gbmZzZXJyX2Rl bGVnX3Jldm9rZWQ7DQo+ICsJCXJldHVybiBuZnNlcnJfYmFkX3N0YXRlaWQ7DQo+ICsJfQ0KPiAg CXJldHVybiBuZnNfb2s7DQo+ICB9DQo+ICANCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBO RlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1c3RAcHJpbWFy eWRhdGEuY29tDQo=