Return-Path: Received: from smtp.gentoo.org ([140.211.166.183]:40222 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764096AbdKRByH (ORCPT ); Fri, 17 Nov 2017 20:54:07 -0500 Subject: Re: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11 To: Linus Torvalds Cc: Kees Cook , Emese Revfy , Al Viro , Bruce Fields , "Darrick J. Wong" , Linux Kernel Mailing List , Linux NFS Mailing List , stable , Thorsten Leemhuis , "kernel-hardening@lists.openwall.com" References: <40ad7c6e-f0d7-959a-bf29-d3e3843f5d31@gentoo.org> <23f7da04-95f7-24e7-ee70-ce40c5b8fee3@gentoo.org> <67939ef3-29c6-762c-7afe-46cc69630d95@gentoo.org> <3d948180-6bd7-c4e9-5ac8-5baef9cc15a7@gentoo.org> <09f2480f-e8e8-645b-6d94-b6ae4ca47806@gentoo.org> From: Patrick McLean Message-ID: <242b16cd-056a-1499-2b65-69084dac1d8d@gentoo.org> Date: Fri, 17 Nov 2017 17:54:03 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 2017-11-17 04:55 PM, Linus Torvalds wrote: > On Fri, Nov 17, 2017 at 4:27 PM, Patrick McLean wrote: >> >> I am still getting the crash at d9e12200852d, I figured I would >> double-check the "good" and "bad" kernels before starting a full bisect. > > .. but without GCC_PLUGIN_RANDSTRUCT it's solid? Yes, without GCC_PLUGIN_RANDSTRUCT it's solid. > Kees removed even the baseline "randomize pure function pointer > structures", so at that commit, nothing should be randomized. > > But maybe the plugin code itself ends up confusing gcc somehow? > > Even when it doesn't actually do that "relayout_struct()" on the > structure, it always does those TYPE_ATTRIBUTES() games.