Return-Path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:35540 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbdKSK65 (ORCPT ); Sun, 19 Nov 2017 05:58:57 -0500 MIME-Version: 1.0 In-Reply-To: <20171118185011.4729-1-trond.myklebust@primarydata.com> References: <20171118185011.4729-1-trond.myklebust@primarydata.com> From: Geert Uytterhoeven Date: Sun, 19 Nov 2017 11:58:56 +0100 Message-ID: Subject: Re: [PATCH] NFSv4: Ensure gcc 4.4.4 can compile initialiser for "invalid_stateid" To: Trond Myklebust Cc: Anna Schumaker , Boris Ostrovsky , "linux-nfs @ vger . kernel . org" , "linux-kernel @ vger . kernel . org" Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: On Sat, Nov 18, 2017 at 7:50 PM, Trond Myklebust wrote: > gcc 4.4.4 is too old to have full C11 anonymous union support, so > the current initialiser fails to compile. Thanks! Works fine with gcc-4.1.2, too. > Reported-by: Boris Ostrovsky > Signed-off-by: Trond Myklebust Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds