Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:51590 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933650AbeAJRNl (ORCPT ); Wed, 10 Jan 2018 12:13:41 -0500 Subject: Re: [PATCH RFC 0/3] Add server-side support for junctions to nfs-utils To: Chuck Lever , Bruce Fields Cc: Linux NFS Mailing List References: <20180108213356.20133.54161.stgit@manet.1015granger.net> <20180109192100.GB18087@fieldses.org> <492B1883-83EE-40AF-AA8C-1B797D842E5E@oracle.com> From: Steve Dickson Message-ID: <01acd06d-98d4-c6ff-5ef1-b6edbb447405@RedHat.com> Date: Wed, 10 Jan 2018 12:13:39 -0500 MIME-Version: 1.0 In-Reply-To: <492B1883-83EE-40AF-AA8C-1B797D842E5E@oracle.com> Content-Type: text/plain; charset=utf-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 01/09/2018 02:36 PM, Chuck Lever wrote: > > >> On Jan 9, 2018, at 2:21 PM, bfields@fieldses.org wrote: >> >> Thanks for doing this! I may not get the chance to do a real review, >> but I'm in favor of the basic idea. > > How do you feel about building support for junctions into mountd, > and getting rid of the libnfsjunct DLL ? I would rather not put new functionality in daemons that needs rpcbind. With the idea of, someday, having clean v4-only configuration (aka no mountd, statd, or lockd). >> >> On Mon, Jan 08, 2018 at 04:49:50PM -0500, Chuck Lever wrote: >>> THIS IS AN UNTESTED RFC SERIES. I'm posting this for review only. >>> >>> A while back I announced the deprecation of fedfs-utils. There were >>> a handful of components in fedfs-utils that we decided to keep. One >>> of those keepers was the "nfsref" command. (The other was autofs >>> support for /nfs4, which I hope Ian Kent is making progress on ;-) >>> >>> This is an RFC patch series to introduce "nfsref" to nfs-utils, >>> minus the overhead of the LDAP / FedFS machinery. It also adds a >>> version of libnfsjunct which mountd can dynamically load to handle >>> non-FedFS junctions, replacing the same part from fedfs-utils. >>> >>> I didn't apply a lot of brain cells to this port, so it's perhaps a >>> little larger than it needs to be. Still, it achieves a completely >>> LDAP-free implementation. I'm interested in comments about the >>> approach before I do more testing and refinement. >>> >>> ./configure --enable-junction --enable-caps >>> >>> is needed before building. >>> >>> Perhaps one thing that can be done is simply getting rid of the DLL >>> and building junction support into mountd. I'm not sure if a >>> transition period is necessary where the DLL is retained for a bit >>> until fedfs-utils is entirely gone. Does anything but mountd use >>> libnfsjunct ? So nfsref is to manage NFS referrals... got it... which I think is a good thing to put into nfs-utils.. but again I wold like to move a way from using mountd for exporting stuff. I must admit my memory on how referrals work is a bet strained, but does it make any sense at all to move the referral code out of mountd and into a new command maybe called nfsexport. Then have the kernel call up to that command (similar to how it does with nfsidmap) to get the referrals info. That way only nfsexport would link with libnfsjunct. Now I realize this has nothing to do with putting nfsref into nfs-utils... I'm all for that... and I'm not asking you to do the work... I'm thinking out loud... Does it make sense to use this opportunity to build new mechanisms to handle referrals and then possibly all exports?? Again, with the idea of eliminating need for legacy daemons. steved.