Date: Fri, 19 Jan 2018 12:58:20 -0700
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Anna Schumaker <Anna.Schumaker@Netapp.com>,
        linux-rdma@vger.kernel.org,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 01/12] rdma/ib: Add trace point macros to display
 human-readable values
Message-ID: <20180119195820.GC3437@ziepe.ca>
References: <20171220210236.29321.59307.stgit@manet.1015granger.net>
 <20171220213023.29321.97527.stgit@manet.1015granger.net>
 <1245d090-99ee-c517-5f8f-afdb7ffc0456@Netapp.com>
 <20180118223446.GB17294@ziepe.ca>
 <73857AF2-BE14-451B-AC9D-1F2B2395CCB7@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <73857AF2-BE14-451B-AC9D-1F2B2395CCB7@oracle.com>
Sender: linux-nfs-owner@vger.kernel.org

On Fri, Jan 19, 2018 at 11:19:20AM -0500, Chuck Lever wrote:
> 
> 
> > On Jan 18, 2018, at 5:34 PM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
> > 
> > On Thu, Jan 18, 2018 at 04:49:20PM -0500, Anna Schumaker wrote:
> >> Hi Folks,
> >> 
> >> On 12/20/2017 04:30 PM, Chuck Lever wrote:
> >>> These can be shared with all kernel ULPs, and more can easily be
> >>> added as needed.
> >>> 
> >>> Note: checkpatch.pl has some heartburn with the TRACE_DEFINE_ENUM
> >>> macros and the LIST macros. These follow the same style as other
> >>> header files under include/tracing/events , thus should be
> >>> considered acceptable exceptions.
> >>> 
> >>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> >>> include/trace/events/rdma.h |  128 +++++++++++++++++++++++++++++++++++++++++++
> >>> 1 file changed, 128 insertions(+)
> >>> create mode 100644 include/trace/events/rdma.h
> >> 
> >> Just checking that it's okay to send this through the NFS tree,
> >> since it goes along with the rest of Chuck's patches?
> > 
> > New file, won't create any conflicts, so should be fine.
> > 
> > Is this API or anything that needs a really special look?
> > 
> >>> +++ b/include/trace/events/rdma.h
> >>> @@ -0,0 +1,128 @@
> >>> +/*
> >>> + * Copyright (c) 2017 Oracle.  All rights reserved.
> >>> + */
> > 
> > This should have a SPDX header though, from what I understand.
> 
> If Anna adds SPDX headers to the files introduced in this series,
> can we get an Acked-by for this patch from one of the RDMA
> maintainers? Or is that not necessary?

Probably a MAINTAINERS file entry too.

The patch looks OK to me, it is just boilerplate to make the enums
work right.

Yes, you should have Ack's from maintainers when going through another
tree. Send a v2 of this patch and I can ack it for you.

Jason